ROX-19064: Scanner V4 Automated Tests (Image Scanning)#19673
Draft
ROX-19064: Scanner V4 Automated Tests (Image Scanning)#19673
Conversation
Add null guard to found checks so that it actually retries when image not found yet vs. failing with NullPointerException. This was causing CI flakes during testing.
…y flag - Creates a ScannerV4Integration type for tests to use (will be part of future commits) - The Scanner V4 integration cannot be deleted in Central by design, the new isDeletable() method allows tests to act accordingly. - Makes isTestable() for StackRoxScannerIntegration conditional on Scanner V4 being enabled. When Scanner V4 is enabled StackRox Scanner is not reachable for image scans (exception: delegated scanning, but that is not tested in groovy tests)
Contributor
Author
|
/test all |
Contributor
|
Images are ready for the commit at b4d8dbf. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19673 +/- ##
==========================================
+ Coverage 49.37% 49.38% +0.01%
==========================================
Files 2742 2743 +1
Lines 206921 207037 +116
==========================================
+ Hits 102165 102245 +80
- Misses 97172 97212 +40
+ Partials 7584 7580 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of a series of changes that modify groovy tests to work with both StackRox Scanner and Scanner V4.
Scanner V4 is not enabled yet, this is prep work so that it can be enabled in a future PR.
Updates the Image Scanning Tests to work with both scanners.
Stacked on top of
User-facing documentation
Testing and quality
Automated testing
How I validated my change
Against StackRox Scanner these changes will be tested by CI as part of this PR
Against Scanner V4 these changes were validated in #19236