Skip to content

ROX-33564: Add gzip, less, and tar packages to ubi-micro images#19985

Merged
janisz merged 2 commits intomasterfrom
ROX-33564/common-pacakges
Apr 15, 2026
Merged

ROX-33564: Add gzip, less, and tar packages to ubi-micro images#19985
janisz merged 2 commits intomasterfrom
ROX-33564/common-pacakges

Conversation

@janisz
Copy link
Copy Markdown
Contributor

@janisz janisz commented Apr 14, 2026

These common Unix utilities are useful for debugging, log inspection, and file operations within containers. Adding them to all ubi-micro-based images (main, roxctl, scanner, operator) provides consistent tooling across the platform.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

janisz and others added 2 commits April 14, 2026 14:16
These common Unix utilities are useful for debugging, log inspection, and
file operations within containers. Adding them to all ubi-micro-based images
(main, roxctl, scanner, operator) provides consistent tooling across the
platform.

Changes:
- Updated rpms.in.yaml with gzip, less, tar
- Regenerated rpms.lock.yaml for all architectures
- Updated all konflux.Dockerfiles to install packages
- Updated all regular Dockerfiles to install packages

Code partially generated with AI assistance.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 14, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions github-actions bot added area/helm area/operator area/scanner konflux-build Run Konflux in PR. Push commit to trigger it. labels Apr 14, 2026
@janisz janisz marked this pull request as ready for review April 14, 2026 12:48
@janisz janisz requested review from a team and rhacs-bot as code owners April 14, 2026 12:48
@janisz janisz changed the title Add gzip, less, and tar packages to ubi-micro images ROX-33564: Add gzip, less, and tar packages to ubi-micro images Apr 14, 2026
@rhacs-bot rhacs-bot requested a review from a team April 14, 2026 12:48
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.57%. Comparing base (9ef4d62) to head (694a4d5).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #19985   +/-   ##
=======================================
  Coverage   49.56%   49.57%           
=======================================
  Files        2764     2764           
  Lines      208442   208442           
=======================================
+ Hits       103323   103328    +5     
+ Misses      97464    97460    -4     
+ Partials     7655     7654    -1     
Flag Coverage Δ
go-unit-tests 49.57% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 14, 2026

🚀 Build Images Ready

Images are ready for commit a778eb6. To use with deploy scripts:

export MAIN_IMAGE_TAG=4.11.x-654-ga778eb6bc8

@github-actions
Copy link
Copy Markdown
Contributor

/konflux-retest roxctl-on-push

@github-actions
Copy link
Copy Markdown
Contributor

/konflux-retest operator-bundle-on-push

@janisz janisz requested a review from msugakov April 14, 2026 13:15
@github-actions
Copy link
Copy Markdown
Contributor

/konflux-retest scanner-v4-db-on-push

@github-actions
Copy link
Copy Markdown
Contributor

/konflux-retest roxctl-on-push

@github-actions
Copy link
Copy Markdown
Contributor

/konflux-retest scanner-v4-db-on-push

@github-actions
Copy link
Copy Markdown
Contributor

/konflux-retest operator-bundle-on-push

@github-actions
Copy link
Copy Markdown
Contributor

/konflux-retest central-db-on-push

Copy link
Copy Markdown
Contributor

@msugakov msugakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure Konflux CI succeeds. Conforma is optional, it does not have to suceed.

@msugakov
Copy link
Copy Markdown
Contributor

/konflux-retest create-custom-snapshot

@janisz
Copy link
Copy Markdown
Contributor Author

janisz commented Apr 14, 2026

/retest

janisz added a commit to stackrox/scanner that referenced this pull request Apr 14, 2026
Migrates scanner, scanner-db, and vulnerabilities images from ubi9-minimal
to ubi9-micro base, following established patterns from stackrox/stackrox
and stackrox/collector repositories.

Changes:
- Scanner images: Multi-stage build with package_installer for runtime deps
- Scanner-DB images: Complex migration with PostgreSQL via chroot user/locale setup
- Vulnerabilities image: Simple base image change (minimal deps)
- Tekton configs: Added RPM prefetch + ACTIVATION_KEY for hermetic builds
- rpms.in.yaml: Scanner packages (excludes coreutils - ubi9-micro has coreutils-single)
- rpms.lock.yaml: Generated lockfile for all architectures

Benefits:
- ~30-35% image size reduction (ubi9-micro ~28MB vs ubi9-minimal ~92MB)
- Improved security - package managers removed from runtime
- Reduced CVE exposure surface
- Alignment with organization-wide ubi9-micro standardization

Technical details:
- Scanner keeps rpm package (required for image scanning functionality)
- PostgreSQL user created as UID/GID 70 via chroot
- Locale set to en_US.UTF-8 via chroot
- Konflux builds use SHA256-pinned base images
- All scripts require bash (not sh)

Reference PRs:
- stackrox/stackrox#17431 (scanner-db migration)
- stackrox/stackrox#17430 (scanner migration)
- stackrox/collector#3021 (collector migration pattern)
- stackrox/stackrox#19653 (main image migration)
- stackrox/stackrox#19985 (debugging utilities)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 14, 2026

@janisz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-21-qa-e2e-tests 694a4d5 link false /test ocp-4-21-qa-e2e-tests
ci/prow/ocp-4-12-qa-e2e-tests 694a4d5 link false /test ocp-4-12-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@janisz
Copy link
Copy Markdown
Contributor Author

janisz commented Apr 15, 2026

/retest

@janisz
Copy link
Copy Markdown
Contributor Author

janisz commented Apr 15, 2026

Tested

docker run -it --entrypoint /bin/sh quay.io/rhacs-eng/release-roxctl:4.11.0-644-g694a4d5a26-fast
Unable to find image 'quay.io/rhacs-eng/release-roxctl:4.11.0-644-g694a4d5a26-fast' locally
4.11.0-644-g694a4d5a26-fast: Pulling from rhacs-eng/release-roxctl
130735c348da: Pull complete
bd9ddc54bea9: Pull complete
9d168756837e: Pull complete
Digest: sha256:24c9dbc3587cf43f97811b1289374f78055e4297947e49bc08f34fd07d171d50
Status: Downloaded newer image for quay.io/rhacs-eng/release-roxctl:4.11.0-644-g694a4d5a26-fast
sh-5.1$ tar
tar: You must specify one of the '-Acdtrux', '--delete' or '--test-label' options
Try 'tar --help' or 'tar --usage' for more information.
sh-5.1$ less
Missing filename ("less --help" for help)
sh-5.1$ gzip
gzip: compressed data not written to a terminal. Use -f to force compression.
For help, type: gzip -h
sh-5.1$
exit

@janisz janisz merged commit a778eb6 into master Apr 15, 2026
124 of 135 checks passed
@janisz janisz deleted the ROX-33564/common-pacakges branch April 15, 2026 08:55
vikin91 pushed a commit that referenced this pull request Apr 16, 2026
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/helm area/operator area/scanner konflux-build Run Konflux in PR. Push commit to trigger it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants