Skip to content

ROX-34020: Add ContainerType enum to Container proto#19989

Merged
AlexVulaj merged 1 commit intomasterfrom
AlexVulaj/ROX-34020-container-type-enum
Apr 15, 2026
Merged

ROX-34020: Add ContainerType enum to Container proto#19989
AlexVulaj merged 1 commit intomasterfrom
AlexVulaj/ROX-34020-container-type-enum

Conversation

@AlexVulaj
Copy link
Copy Markdown
Contributor

@AlexVulaj AlexVulaj commented Apr 14, 2026 •
edited
Loading

Description

Adds a ContainerType enum to the Container protobuf message in proto/storage/deployment.proto, enabling StackRox to distinguish between regular, init, and other containers within a deployment.

Files to review:

  • proto/storage/deployment.proto — the actual change (enum + field)
  • proto/storage/proto.lock — protolock update
  • pkg/search/options.go — register "Container Type" as a search field label

Everything else is generated by our build tools.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

  • Verified that protobuf code generation (make proto-generated-srcs and make go-generated-srcs) completes successfully and produces the expected output.

@AlexVulaj AlexVulaj requested a review from a team as a code owner April 14, 2026 15:21
@AlexVulaj AlexVulaj force-pushed the AlexVulaj/ROX-34020-container-type-enum branch from 18ce1ec to 5cec19b Compare April 14, 2026 15:27
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 14, 2026 •
edited
Loading

🚀 Build Images Ready

Images are ready for commit d721274. To use with deploy scripts:

export MAIN_IMAGE_TAG=4.11.x-658-gd721274f6c

@AlexVulaj AlexVulaj force-pushed the AlexVulaj/ROX-34020-container-type-enum branch 3 times, most recently from 67b2295 to 350be15 Compare April 14, 2026 17:06
@AlexVulaj
Copy link
Copy Markdown
Contributor Author

AlexVulaj commented Apr 14, 2026

/test gke-nongroovy-e2e-tests

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 22.72727% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.61%. Comparing base (7275fcd) to head (4f3aa7c).
⚠️ Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
central/graphql/resolvers/generated.go 10.52% 17 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #19989      +/-   ##
==========================================
+ Coverage   49.56%   49.61%   +0.04%     
==========================================
  Files        2764     2765       +1     
  Lines      208438   208617     +179     
==========================================
+ Hits       103313   103502     +189     
+ Misses      97469    97459      -10     
  Partials     7656     7656
Flag Coverage Δ
go-unit-tests 49.61% <22.72%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AlexVulaj AlexVulaj force-pushed the AlexVulaj/ROX-34020-container-type-enum branch from 350be15 to 4f3aa7c Compare April 14, 2026 19:38
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 14, 2026

@AlexVulaj: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-12-nongroovy-e2e-tests 4f3aa7c link false /test ocp-4-12-nongroovy-e2e-tests
ci/prow/ocp-4-12-qa-e2e-tests 4f3aa7c link false /test ocp-4-12-qa-e2e-tests
ci/prow/ocp-4-21-qa-e2e-tests 4f3aa7c link false /test ocp-4-21-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@AlexVulaj AlexVulaj merged commit d721274 into master Apr 15, 2026
99 of 103 checks passed
@AlexVulaj AlexVulaj deleted the AlexVulaj/ROX-34020-container-type-enum branch April 15, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dashrews78 dashrews78 dashrews78 approved these changes

Assignees

No one assigned

Labels

area/central area/postgres

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AlexVulaj @dashrews78