ROX-33816: proto changes for deployment soft deletes#19991
Draft
ROX-33816: proto changes for deployment soft deletes#19991
Conversation
|
Skipping CI for Draft Pull Request. |
Contributor
🚀 Build Images ReadyImages are ready for commit 4a1d1c4. To use with deploy scripts: export MAIN_IMAGE_TAG=4.11.x-668-g4a1d1c4a6e |
2c46d47 to
3175673
Compare
e0e556b to
b1d0c6d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19991 +/- ##
==========================================
+ Coverage 49.65% 49.67% +0.01%
==========================================
Files 2765 2765
Lines 208823 209072 +249
==========================================
+ Hits 103698 103849 +151
- Misses 97458 97546 +88
- Partials 7667 7677 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b1d0c6d to
9aec835
Compare
bd51b28 to
dffeb27
Compare
dffeb27 to
51ea8df
Compare
51ea8df to
4a1d1c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The purpose of this PR stack is to support soft deletes for deployments. That is, when workloads are deleted with the kube-api, the corresponding deployments in ACS are marked as deleted. This is done to surface such deployments and their vulnerabilities to the user. Deleted deployments are then pruned from the database in regular intervals. Also see ACS Soft-Delete for Deployments for high level discussion.
I have decided to go with a single timestamp to reduce the overall proto fields. The pruning time would then be calculated dynamically as
deleted_at + pruning_interval. Thestateenum is intended to make filtering and querying more convenient for the UI (as there is no need to handle timestamps directly).User-facing documentation
Testing and quality
Automated testing
How I validated my change
change me!