Skip to content

ROX-33741: Add component for filter in image vulnerability report#19993

Open
pedrottimark wants to merge 4 commits intomasterfrom
ROX-33741-CompoundSearchFilterDescriptionListGroups
Open

ROX-33741: Add component for filter in image vulnerability report#19993
pedrottimark wants to merge 4 commits intomasterfrom
ROX-33741-CompoundSearchFilterDescriptionListGroups

Conversation

@pedrottimark
Copy link
Copy Markdown
Contributor

@pedrottimark pedrottimark commented Apr 14, 2026 •
edited
Loading

Description

Review: Hide space in case refactoring becomes clearer.

Objective

Provide equivalent filter for schduled reports as view-based reports

Analysis

  1. ViewBasedReportJobDetails.tsx file renders CompoundSearchFilterLabels element for consistency with results page.

  2. CompoundSearchFilterLabels.tsx file computes labelGroupDescriptions array that is also relevant for:

    • ImageVulnerabilityFiltersView
    • ImageVulnerabilityFiltersStep

Solution part 1

  1. Edit src/Components/CompoundSearchFilter/utils/utils.tsx file.

    • Write getCompoundSearchFilterLabelDescriptions function.

  2. Add src/Components/CompoundSearchFilter/components/CompoundSearchFilterDescriptionListGroups.tsx file.

Solution part 2

  1. Replace LabelGroup with Flex column layout for attribute values.

  2. Simplify headings and description lists in ViewBasedReportJobDetails.tsx file.

    Replace placeholder CompoundSearchFilterLabels with CompoundSearchFilterDescriptionListGroups element.

  3. Replace temporary label with Area of concern and reorder attributes for view-based report in searchConfig.ts file.

Residue

  1. Investigate more consistent layout for view-based report job details.

  2. Investigate pro and con of modal versus page.

User-facing documentation

  • CHANGELOG.md update is not needed
  • documentation PR is not needed

Testing and quality

  • the change is production ready and the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

  1. npm run tsc in ui/apps/platform folder.
  2. npm run lint:fast-dev in ui/apps/platform folder.
  3. npm run start in ui/apps/platform folder with staging demo as central

Manual testing

  1. Visit /main/vulnerabilities/platform

    Select search filter criteria to see CompoundSearchFilterLabels element after refactor.
    CompoundSearchFilterLabels

  2. Visit /main/vulnerabilities/reports/view-based and then click a link.

    Before changes with compound search filter labels:
    ViewBasedReportJobDetails_baseline

    After changes with description list groups:
    ViewBasedReportJobDetails_improved

@pedrottimark pedrottimark requested a review from bradr5 April 14, 2026 20:14
@pedrottimark pedrottimark requested a review from a team as a code owner April 14, 2026 20:14
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 14, 2026 •
edited
Loading

🚀 Build Images Ready

Images are ready for commit 1329c77. To use with deploy scripts:

export MAIN_IMAGE_TAG=4.11.x-654-g1329c778cb

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.61%. Comparing base (e07a85c) to head (1329c77).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #19993   +/-   ##
=======================================
  Coverage   49.61%   49.61%           
=======================================
  Files        2765     2765           
  Lines      208596   208643   +47     
=======================================
+ Hits       103493   103520   +27     
- Misses      97444    97467   +23     
+ Partials     7659     7656    -3
Flag Coverage Δ
go-unit-tests 49.61% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 15, 2026

@pedrottimark: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-12-nongroovy-e2e-tests 1329c77 link false /test ocp-4-12-nongroovy-e2e-tests
ci/prow/ocp-4-21-ui-e2e-tests 1329c77 link false /test ocp-4-21-ui-e2e-tests
ci/prow/ocp-4-21-nongroovy-e2e-tests 1329c77 link false /test ocp-4-21-nongroovy-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pedrottimark
Copy link
Copy Markdown
Contributor Author

pedrottimark commented Apr 15, 2026

gke-ui-e2e-tests passes and 3 non-required tests might have failed because of quote problem recently reported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bradr5 bradr5 Awaiting requested review from bradr5

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

area/ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@pedrottimark