Skip to content

ROX-9766: Add severity column to Image CVEs and Node CVEs tables #2768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sachaudh merged 1 commit into from
Aug 22, 2022
Merged

ROX-9766: Add severity column to Image CVEs and Node CVEs tables #2768

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ui/apps/platform/src/Containers/VulnMgmt/List/Cves/ListCVEs.utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ export function getFilteredCVEColumns(columns, workflowState) {
const shouldKeepCveType =
currentEntityType === entityTypes.CVE || currentEntityType === entityTypes.CLUSTER_CVE;

const shouldKeepSeverity =
currentEntityType === entityTypes.IMAGE_CVE || currentEntityType === entityTypes.NODE_CVE;

return columns.filter((col) => {
switch (col.accessor) {
// TODO: remove after generic CVE list is removed
Expand All @@ -55,7 +58,7 @@ export function getFilteredCVEColumns(columns, workflowState) {
return shouldKeepEntitiesColumn;
}
case 'severity': {
return shouldKeepDiscoveredAtImageColumn;
return shouldKeepSeverity || shouldKeepDiscoveredAtImageColumn;
Copy link
Copy Markdown
Contributor

@md2119 md2119 Aug 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you checking for shouldKeepDiscoveredAtImageColumn to determine the visibility of severity?

Copy link
Copy Markdown
Contributor Author

@sachaudh sachaudh Aug 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like we use that to determine whether to show the severity column. If you git blame you can track it down to this PR https://github.com/stackrox/rox/pull/8080. It seems like he added it according to that PR. All I know is that we want to show the severity for the Image CVEs and Node CVEs tables so I'm adding that conditional logic to display it for those. I don't want to mess around too much with what's here right now since we will eventually make changes to VM soon. If you want to dig into why it was added, maybe you can ask Gorman for clarification.

}
default: {
return true;
Expand Down