Skip to content

Conditionally skip with hasFeatureFlag in vulnmanagement integration tests #3308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pedrottimark merged 1 commit into from
Oct 5, 2022
Merged

Conditionally skip with hasFeatureFlag in vulnmanagement integration tests #3308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ui/apps/platform/cypress/integration/vulnmanagement/clusterCvesListPages.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,7 @@ describe('Vulnerability Management Cluster (Platform) CVEs', () => {

// Some tests might fail in local deployment.

// TODO Investigate why CI displays No clusters instead of 2 clusters.
it.skip('should display links for clusters', () => {
it('should display links for clusters', () => {
verifySecondaryEntities(
entitiesKey,
'clusters',
Expand Down
30 changes: 23 additions & 7 deletions ui/apps/platform/cypress/integration/vulnmanagement/dashboard.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,17 +76,27 @@ describe('Vulnerability Management Dashboard', () => {
});
});

// TODO Delete skip when we delete ROX_POSTGRES_DATASTORE feature flag.
it('should show same number of Image CVEs in menu item and entities list', function () {
if (!hasFeatureFlag('ROX_POSTGRES_DATASTORE')) {
this.skip();
}

it.skip('should show same number of Image CVEs in menu item and entities list', () => {
verifyVulnerabilityManagementDashboardCVEs('image-cves', /^\d+ Image CVEs?$/);
});

it.skip('should show same number of Node CVEs in menu item and entities list', () => {
it('should show same number of Node CVEs in menu item and entities list', function () {
if (!hasFeatureFlag('ROX_POSTGRES_DATASTORE')) {
this.skip();
}

verifyVulnerabilityManagementDashboardCVEs('node-cves', /^\d+ Node CVEs?$/);
});

it.skip('should show same number of Cluster (Platform) CVEs in menu item and entities list', () => {
it('should show same number of Cluster (Platform) CVEs in menu item and entities list', function () {
if (!hasFeatureFlag('ROX_POSTGRES_DATASTORE')) {
this.skip();
}

verifyVulnerabilityManagementDashboardCVEs('cluster-cves', /^\d+ Platform CVEs?$/);
});

Expand Down Expand Up @@ -142,9 +152,11 @@ describe('Vulnerability Management Dashboard', () => {
);
});

// TODO Delete skip when we delete ROX_POSTGRES_DATASTORE feature flag.
it('should navigate to the node components list', function () {
if (!hasFeatureFlag('ROX_POSTGRES_DATASTORE')) {
this.skip();
}

it.skip('should navigate to the node components list', () => {
visitVulnerabilityManagementDashboard();

const entitiesKey = 'node-components';
Expand All @@ -156,7 +168,11 @@ describe('Vulnerability Management Dashboard', () => {
);
});

it.skip('should navigate to the image components list', () => {
it('should navigate to the image components list', function () {
if (!hasFeatureFlag('ROX_POSTGRES_DATASTORE')) {
this.skip();
}

visitVulnerabilityManagementDashboard();

const entitiesKey = 'image-components';
Expand Down