Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ulfjack/ryu
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: ulfjack/ryu
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: java-reduce-lookup-table
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on May 28, 2018

  1. Rewrite Java implementation to use 32-bit factors 

    This puts it in line with the C implementation fallback code. This may
be required in order to half the lookup table size, which may require
higher bit counts, and the previous implementation was limited to 4*31 =
124 bits.

This may also be a deadend. If the code becomes significantly slower in
a way that we cannot recover from, then we may have to undo this.
    @ulfjack
    ulfjack committed May 28, 2018
    Configuration menu
    Copy the full SHA
    1a1de0d View commit details
    Browse the repository at this point in the history

  2. Only access even-numbered entries in the lookup table 

    Naively, this requires 65 bit. However, we can immediately divide by 10
since we know that the last digit is unnecessary, and that is the same
as dividing by 2 and then by 5. We do this by increasing the shift
distance by one, so it's essentially for free.

However, this is somewhat costly in terms of performance.
    @ulfjack
    ulfjack committed May 28, 2018
    Configuration menu
    Copy the full SHA
    20b0707 View commit details
    Browse the repository at this point in the history
Loading