fix(node:timers): add missing methods to Timeout polyfill

pi0 · pi0 · commit b6934a525e13 · 2025-04-16T11:35:37.000+02:00
diff --git a/src/runtime/node/internal/timers/set-interval.ts b/src/runtime/node/internal/timers/set-interval.ts
@@ -3,7 +3,7 @@ import { Timeout } from "./timeout.ts";
 export async function* setIntervalFallbackPromises<T = void>(
   delay?: number,
   value?: T,
-): AsyncIterable<T> {
+): NodeJS.AsyncIterator<T> {
   yield value as T;
 }
 
diff --git a/src/runtime/node/internal/timers/timeout.ts b/src/runtime/node/internal/timers/timeout.ts
@@ -1,9 +1,17 @@
+import { createNotImplementedError } from "../../../_internal/utils.ts";
+
 export class Timeout<TArgs extends any[]> implements NodeJS.Timeout {
   constructor(callback: TimerHandler, args: TArgs) {
     if (typeof callback === "function") {
       callback(...args);
     }
   }
+  close(): this {
+    throw createNotImplementedError("node.timers.timeout.close");
+  }
+  _onTimeout(...args: any[]): void {
+    throw createNotImplementedError("node.timers.timeout._onTimeout");
+  }
   ref() {
     return this;
   }

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@ import { Timeout } from "./timeout.ts";`
`3`	`3`	`export async function* setIntervalFallbackPromises<T = void>(`
`4`	`4`	`delay?: number,`
`5`	`5`	`value?: T,`
`6`		`-): AsyncIterable<T> {`
	`6`	`+): NodeJS.AsyncIterator<T> {`
`7`	`7`	`yield value as T;`
`8`	`8`	`}`
`9`	`9`
Original file line number	Diff line number	Diff line change
`@@ -1,9 +1,17 @@`
	`1`	`+import { createNotImplementedError } from "../../../_internal/utils.ts";`
	`2`	`+`
`1`	`3`	`export class Timeout<TArgs extends any[]> implements NodeJS.Timeout {`
`2`	`4`	`constructor(callback: TimerHandler, args: TArgs) {`
`3`	`5`	`if (typeof callback === "function") {`
`4`	`6`	`callback(...args);`
`5`	`7`	`}`
`6`	`8`	`}`
	`9`	`+ close(): this {`
	`10`	`+ throw createNotImplementedError("node.timers.timeout.close");`
	`11`	`+ }`
	`12`	`+ _onTimeout(...args: any[]): void {`
	`13`	`+ throw createNotImplementedError("node.timers.timeout._onTimeout");`
	`14`	`+ }`
`7`	`15`	`ref() {`
`8`	`16`	`return this;`
`9`	`17`	`}`