From b0c98f6487b15bfb33c2cea29c808810eab775d6 Mon Sep 17 00:00:00 2001 From: Victor Berchet Date: Mon, 13 Oct 2025 09:27:18 +0200 Subject: [PATCH 1/3] fix(cluster): a few fixes --- src/runtime/node/cluster.ts | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/src/runtime/node/cluster.ts b/src/runtime/node/cluster.ts index ef606a1b..878afad9 100644 --- a/src/runtime/node/cluster.ts +++ b/src/runtime/node/cluster.ts @@ -2,6 +2,7 @@ import type nodeCluster from "node:cluster"; import type { Cluster as NodeCluster, Worker as NodeClusterWorker, + ClusterSettings as NodeClusterSettings, } from "node:cluster"; import { EventEmitter } from "node:events"; import { notImplemented } from "../_internal/utils.ts"; @@ -58,8 +59,9 @@ export class Worker extends EventEmitter implements NodeClusterWorker { destroy(signal?: string): void { this._connected = false; } - disconnect(): void { + disconnect(): this { this._connected = false; + return this; } } @@ -73,17 +75,17 @@ class _Cluster extends EventEmitter implements NodeCluster { schedulingPolicy = SCHED_RR; settings = settings; workers = workers; - setupPrimary() { - return setupPrimary(); + setupPrimary(_settings?: NodeClusterSettings): void { + setupPrimary(); } - setupMaster() { - return setupPrimary(); + setupMaster(_settings?: NodeClusterSettings): void { + setupMaster(); } - disconnect() { - return disconnect(); + disconnect(): void { + disconnect(); } - fork() { - return fork(); + fork(env?: Record) { + return fork(env); } } From be4d17b471648ee2f99240549f1251dababc4e26 Mon Sep 17 00:00:00 2001 From: Victor Berchet Date: Mon, 13 Oct 2025 09:28:32 +0200 Subject: [PATCH 2/3] fixup! add return type --- src/runtime/node/cluster.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/runtime/node/cluster.ts b/src/runtime/node/cluster.ts index 878afad9..b8ed3c89 100644 --- a/src/runtime/node/cluster.ts +++ b/src/runtime/node/cluster.ts @@ -84,7 +84,7 @@ class _Cluster extends EventEmitter implements NodeCluster { disconnect(): void { disconnect(); } - fork(env?: Record) { + fork(env?: Record): NodeClusterWorker { return fork(env); } } From 55d5a060d9133d01efdc5069e8a8f47bac6e4986 Mon Sep 17 00:00:00 2001 From: Victor Berchet Date: Mon, 13 Oct 2025 09:30:37 +0200 Subject: [PATCH 3/3] fixup: any --- src/runtime/node/cluster.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/runtime/node/cluster.ts b/src/runtime/node/cluster.ts index b8ed3c89..c42968b7 100644 --- a/src/runtime/node/cluster.ts +++ b/src/runtime/node/cluster.ts @@ -84,7 +84,7 @@ class _Cluster extends EventEmitter implements NodeCluster { disconnect(): void { disconnect(); } - fork(env?: Record): NodeClusterWorker { + fork(env?: any): NodeClusterWorker { return fork(env); } }