[Masonry] Fix grid-lanes-direction Typed OM crash#57655
Draft
chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
Draft
[Masonry] Fix grid-lanes-direction Typed OM crash#57655chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
Conversation
There was a crash when setting 'grid-lanes-direction' within 'attributeStyleMap'. This fixes the crash by only adding 'normal' as a typed OM supported keyword. Special code was added to StyleValueToCSSValue() to ensure that all other supported keywords are listified to match internal expectations elsewhere in code. Bug: 481737052, 343257585 Change-Id: Ic075623410a154c73e953535cb2b5cd73661f2ad
c0e234c to
35ae1b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a crash when setting 'grid-lanes-direction' within
'attributeStyleMap'. This fixes the crash by only adding 'normal' as a
typed OM supported keyword.
Special code was added to StyleValueToCSSValue() to ensure that all
other supported keywords are listified to match internal expectations
elsewhere in code.
Bug: 481737052, 343257585
Change-Id: Ic075623410a154c73e953535cb2b5cd73661f2ad
Reviewed-on: https://chromium-review.googlesource.com/7548559
WPT-Export-Revision: f175d65a3c6d197d112a60e0aa70e56b5a7a9d5a