fix(core): handle if alias in control flow migration#52181
Closed
cexbrayat wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): handle if alias in control flow migration#52181cexbrayat wants to merge 1 commit intoangular:mainfrom
cexbrayat wants to merge 1 commit intoangular:mainfrom
Conversation
Member
Author
|
This is a naive fix, I'm not sure if there is a better way to find if the condition has an |
JoostK
reviewed
Oct 12, 2023
packages/core/schematics/ng-generate/control-flow-migration/util.ts
Outdated
Show resolved
Hide resolved
e73cc74 to
fbb9103
Compare
packages/core/schematics/ng-generate/control-flow-migration/util.ts
Outdated
Show resolved
Hide resolved
fbb9103 to
f9c74ea
Compare
f9c74ea to
2b8f1b7
Compare
This adds the support of `if ` conditions with `as` clause when migrating to the control flow syntax.
It now adds the required semicolon before the `as` when migrating the template.
Before: `@if (user$ | async as user) {`
After: `@if (user$ | async; as user) {`
2b8f1b7 to
f20f4e9
Compare
crisbeto
approved these changes
Oct 16, 2023
Member
|
This PR was merged into the repository by commit 2003caf. |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Oct 16, 2023
This adds the support of `if ` conditions with `as` clause when migrating to the control flow syntax.
It now adds the required semicolon before the `as` when migrating the template.
Before: `@if (user$ | async as user) {`
After: `@if (user$ | async; as user) {`
PR Close #52181
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
This adds the support of `if ` conditions with `as` clause when migrating to the control flow syntax.
It now adds the required semicolon before the `as` when migrating the template.
Before: `@if (user$ | async as user) {`
After: `@if (user$ | async; as user) {`
PR Close angular#52181
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
This adds the support of
ifconditions withasclause when migrating to the control flow syntax. It now adds the required semicolon before theaswhen migrating the template.What is the new behavior?
Before:
@if (user$ | async as user) {After:
@if (user$ | async; as user) {Does this PR introduce a breaking change?
Other information