Skip to content

Comments

fix(migrations): properly handle ngIfThen cases in CF migration#53256

Closed
jessicajaniuk wants to merge 1 commit intoangular:mainfrom
jessicajaniuk:migration-ngifthen
Closed

fix(migrations): properly handle ngIfThen cases in CF migration#53256
jessicajaniuk wants to merge 1 commit intoangular:mainfrom
jessicajaniuk:migration-ngifthen

Conversation

@jessicajaniuk
Copy link
Contributor

The migration was handling bound casees of [ngIfThenElse] and also needed [ngIfThen].

fixes: #53254

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

The migration was handling bound casees of [ngIfThenElse] and also needed [ngIfThen].

fixes: angular#53254
@jessicajaniuk jessicajaniuk added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: migrations Issues related to `ng update`/`ng generate` migrations labels Nov 29, 2023
@ngbot ngbot bot added this to the Backlog milestone Nov 29, 2023
@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 29, 2023
@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit a359951.

pkozlowski-opensource pushed a commit that referenced this pull request Nov 29, 2023
The migration was handling bound casees of [ngIfThenElse] and also needed [ngIfThen].

fixes: #53254

PR Close #53256
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 30, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
…lar#53256)

The migration was handling bound casees of [ngIfThenElse] and also needed [ngIfThen].

fixes: angular#53254

PR Close angular#53256
rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
…lar#53256)

The migration was handling bound casees of [ngIfThenElse] and also needed [ngIfThen].

fixes: angular#53254

PR Close angular#53256
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
…lar#53256)

The migration was handling bound casees of [ngIfThenElse] and also needed [ngIfThen].

fixes: angular#53254

PR Close angular#53256
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update`/`ng generate` migrations target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Control flow schematic: ngIfThen + ngIfElse inputs are not migrated

4 participants