fix(migrations): fixes control flow migration bugs with ng-template handling#53368
Closed
jessicajaniuk wants to merge 2 commits intoangular:mainfrom
Closed
fix(migrations): fixes control flow migration bugs with ng-template handling#53368jessicajaniuk wants to merge 2 commits intoangular:mainfrom
jessicajaniuk wants to merge 2 commits intoangular:mainfrom
Conversation
…igration When there are ng-templates nested inside other ng-templates, the replacement and removal of the templates gets disrupted. Re-processing the templates in the file along the way resolves this issue. fixes: angular#53362
If a template is passed in as an input, the ng-template will not exist in the same component template. This will leave a template placeholder behind. This fix ensures that template placeholder gets turned into a template outlet. fixes: angular#53361
This was referenced Dec 5, 2023
crisbeto
approved these changes
Dec 5, 2023
Contributor
|
This PR was merged into the repository by commit 01b18a4. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…igration (angular#53368) When there are ng-templates nested inside other ng-templates, the replacement and removal of the templates gets disrupted. Re-processing the templates in the file along the way resolves this issue. fixes: angular#53362 PR Close angular#53368
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
angular#53368) If a template is passed in as an input, the ng-template will not exist in the same component template. This will leave a template placeholder behind. This fix ensures that template placeholder gets turned into a template outlet. fixes: angular#53361 PR Close angular#53368
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this pull request
Jan 26, 2024
…igration (angular#53368) When there are ng-templates nested inside other ng-templates, the replacement and removal of the templates gets disrupted. Re-processing the templates in the file along the way resolves this issue. fixes: angular#53362 PR Close angular#53368
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this pull request
Jan 26, 2024
angular#53368) If a template is passed in as an input, the ng-template will not exist in the same component template. This will leave a template placeholder behind. This fix ensures that template placeholder gets turned into a template outlet. fixes: angular#53361 PR Close angular#53368
amilamen
pushed a commit
to amilamen/angular
that referenced
this pull request
Jan 26, 2024
…igration (angular#53368) When there are ng-templates nested inside other ng-templates, the replacement and removal of the templates gets disrupted. Re-processing the templates in the file along the way resolves this issue. fixes: angular#53362 PR Close angular#53368
amilamen
pushed a commit
to amilamen/angular
that referenced
this pull request
Jan 26, 2024
angular#53368) If a template is passed in as an input, the ng-template will not exist in the same component template. This will leave a template placeholder behind. This fix ensures that template placeholder gets turned into a template outlet. fixes: angular#53361 PR Close angular#53368
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two reported issues with ng-template handling in the control flow migration.
fixes: #53361
fixes: #53362
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?