Skip to content

Upgrade sqlite to 3.51#5553

Merged
zachlefevre merged 3 commits intomainfrom
zlefevre/upgrade_sqlite_to_3_51
Nov 26, 2025
Merged

Upgrade sqlite to 3.51#5553
zachlefevre merged 3 commits intomainfrom
zlefevre/upgrade_sqlite_to_3_51

Conversation

@zachlefevre
Copy link
Member

@zachlefevre zachlefevre commented Nov 19, 2025

Modify patches to apply to 3.51.
Delete patch 0004 which has been upstreamed.

@zachlefevre zachlefevre requested review from a team as code owners November 19, 2025 14:51
@zachlefevre zachlefevre changed the title Upgrade sqlite to 3 51 Upgrade sqlite to 3.51 Nov 19, 2025
@github-actions
Copy link

github-actions bot commented Nov 19, 2025

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

Copy link
Contributor

@justin-mp justin-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments:

  1. Where is the upgrade to 3.51.0?
  2. Please use 3.51.0 as the version, not 3.51. 3.51 does not exist as a SQLite release.

@zachlefevre zachlefevre force-pushed the zlefevre/upgrade_sqlite_to_3_51 branch 2 times, most recently from 83d8155 to 24e9bdf Compare November 19, 2025 15:26
@zachlefevre zachlefevre force-pushed the zlefevre/upgrade_sqlite_to_3_51 branch from 24e9bdf to 2ec367b Compare November 19, 2025 15:46
@zachlefevre zachlefevre force-pushed the zlefevre/upgrade_sqlite_to_3_51 branch 2 times, most recently from 2a2ed97 to 86f2a3d Compare November 25, 2025 19:40
@zachlefevre zachlefevre requested a review from fhanau November 26, 2025 16:01
@zachlefevre zachlefevre force-pushed the zlefevre/upgrade_sqlite_to_3_51 branch 2 times, most recently from 4e6c5f2 to 05e0ff4 Compare November 26, 2025 16:33
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 26, 2025

CodSpeed Performance Report

Merging #5553 will not alter performance

Comparing zlefevre/upgrade_sqlite_to_3_51 (c41942a) with main (7cf6fb9)

Summary

✅ 57 untouched
⏩ 30 skipped1

Footnotes

  1. 30 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

This test relies on output order which is undefined without an `order by`
@zachlefevre zachlefevre force-pushed the zlefevre/upgrade_sqlite_to_3_51 branch from 05e0ff4 to c41942a Compare November 26, 2025 17:28
@zachlefevre zachlefevre merged commit 66fb393 into main Nov 26, 2025
21 of 22 checks passed
@zachlefevre zachlefevre deleted the zlefevre/upgrade_sqlite_to_3_51 branch November 26, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants