Thanks @micheleissa! I'm wondering if we should maybe have two messages: one for when there's no solution opened and one for when there's a solution opened but it's not a git repository? Not sure really, @sguthals what do you think?

@grokys,

I'm wondering if we should maybe have two messages: one for when there's no solution opened and one for when there's a solution opened but it's not a git repository?

I think we should do this with another message for when a repository exists but there is no origin remote defined. At the moment users are given no clues as to what's going on.

Yeah, possibly, but that sounds like a separate PR to me?

Yeah, possibly, but that sounds like a separate PR to me?

I just wanted to mention there were a few different things we might want to check for -- eventually. 😄

So will this pr be accepted or not?

@grokys yes! I agree with:

one for when there's no solution opened and one for when there's a solution opened but it's not a git repository?

@micheleissa Are you up for making that distinction as part of this pr?

@sguthals I can try if it is easy to know there is a an opened non-git solution. I might ask for some directions.

I'm not familiar at all with Xaml so I don't know where to begin..all I know for now is the view GenericNotAGitRepositoryView is using NotAGitRepositoryMessage resource. Could you guys shed some light on that and where and when does this panel even displayed?

@micheleissa this is handled by the GitHubPaneViewModel:

https://github.com/github/VisualStudio/blob/master/src/GitHub.App/ViewModels/GitHubPane/GitHubPaneViewModel.cs#L396-L407

This piece of code sets the pane's Content property according to whether a repository exists, and it has a clone URL.

For information on how ViewModels are turned into views you might want to look at our developer documentation:

https://github.com/github/VisualStudio/tree/master/docs/developer

In particular:

https://github.com/github/VisualStudio/blob/master/docs/developer/how-viewmodels-are-turned-into-views.md

@grokys thanks. Do I need to check in https://github.com/github/VisualStudio/blob/master/src/GitHub.App/ViewModels/GitHubPane/GitHubPaneViewModel.cs#L396-L407 if a solution open or not?
and also for a msg 'if not a git' repo I think this is handled already.

@micheleissa yes that's what you'll need to do. You'll want to abstract the "is a solution open?" check into a service so that it can be unit tested.

Hey @micheleissa are you still interested in working on this?

@StanleyGoldman I might take a look at it this next week. Do you guys have a deadline for it?

No, there is no deadline @micheleissa. Just wondering if you were still interested in completing this work.

@meaghanlewis thank you, I'm trying to re-produce the issue but I can't. Have any of you guys managed to produce it and if so could you tell me how? Thanks again.

Closing some very old PRs.