Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Ensure that clone works when Visual Studio is first launched #2219
Conversation
IGitActionsExt is proffered by SccProviderPackage, but isn't advertised. To ensure that getting IGitActionsExt doesn't return null, we first request the SccService which is advertised. This forces SccProviderPackage to load and proffer IGitActionsExt.
Force SccProviderPackage to load by getting IGitExt instead of the internal SccService.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
What this PR does
IGitActionsExtis proffered bySccProviderPackage, but isn't advertised. To ensure that gettingIGitActionsExtdoesn't return null, we first request theIGitExtwhich is advertised. This forcesSccProviderPackageto load and profferIGitActionsExt.How to test
Due to issues installing MEF components when testing using F5, I'd recomend installing this VSIX using DogfoodVsix.
Tools > Options...and setCurrent source control plug-intoNone.Clone or check out code > GitHubClonea repositoryTo do
Unfortunately Team Explorer / GitHub for Visual Studio doesn't notice that a GitHub repository has been loaded and the
GitHubsection doesn't appear on theTeam Explorer - Homepage.At least the clone works and the banner will appear next time the solution is loaded or the current branch changes. I don't think this is a ship blocker. I'll work on a fix in another PR.
Fixes #2218