JS: Add more models for command parsing libraries in js/indirect-command-line-injection #4733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esbena
reviewed
Dec 16, 2020
Contributor
esbena
left a comment
There was a problem hiding this comment.
LGTM. Some minor comments, and a missing change-notes.
...script/ql/src/semmle/javascript/security/dataflow/IndirectCommandInjectionCustomizations.qll
Outdated
Show resolved
Hide resolved
| // `require('meow')(help, {...spec})` => `{a: ..., b: ....}` | ||
| this = DataFlow::moduleImport("meow").getACall() | ||
| or | ||
| // https://www.npmjs.com/package/dashdash |
| /** | ||
| * A source of user input from the command-line parsed by the `commander` library. | ||
| */ | ||
| private class CommanderSource extends Source { |
Contributor
There was a problem hiding this comment.
Should this be a part of ParsedCommandLineArgumentsAsSource above for consistency?
…CommandInjectionCustomizations.qll Co-authored-by: Esben Sparre Andreasen <esbena@github.com>
esbena
approved these changes
Dec 16, 2020
Contributor
esbena
left a comment
There was a problem hiding this comment.
Approved. The changes seem benign wrt. performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.