Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTRIBUTING.md] adds Contributing to Flutter article link #61517

Merged
merged 2 commits into from Jul 24, 2020

Conversation

@AyushBherwani1998
Copy link
Member

@AyushBherwani1998 AyushBherwani1998 commented Jul 15, 2020

Description

Adds Contributing to Flutter: Getting Started to the CONTRIBUTING.md

Related Issues

None

Tests

No code changes.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.
@AyushBherwani1998
Copy link
Member Author

@AyushBherwani1998 AyushBherwani1998 commented Jul 15, 2020

cc:/ @Hixie

I have added the article link in the CONTRIBUTING.md, let me know if I should place it somewhere else in the CONTRIBUTING.md.

@RedBrogdon RedBrogdon requested a review from Hixie Jul 22, 2020
@Hixie
Hixie approved these changes Jul 22, 2020
Copy link
Contributor

@Hixie Hixie left a comment

LGTM

@Hixie
Copy link
Contributor

@Hixie Hixie commented Jul 22, 2020

test exempt: documentation

@fluttergithubbot fluttergithubbot merged commit 7877d46 into flutter:master Jul 24, 2020
19 checks passed
19 checks passed
Google testing Google testing passed!
Details
WIP Ready for review
Details
analyze-linux Task Summary
Details
build_tests-0-linux Task Summary
Details
build_tests-1_last-linux Task Summary
Details
cla/google All necessary CLAs are signed
customer_testing-linux Task Summary
Details
customer_testing-macos Task Summary
Details
customer_testing-windows Task Summary
Details
deploy_gallery-linux Task Summary
Details
deploy_gallery-macos Task Summary
Details
firebase_test_lab_tests-0-linux Task Summary
Details
firebase_test_lab_tests-1-linux Task Summary
Details
firebase_test_lab_tests-2_last-linux Task Summary
Details
flutter-build
Details
hostonly_devicelab_tests-0-linux Task Summary
Details
hostonly_devicelab_tests-1-linux Task Summary
Details
hostonly_devicelab_tests-2-linux Task Summary
Details
hostonly_devicelab_tests-3_last-linux Task Summary
Details
Pragya007 added a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
mingwandroid added a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.