Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upincluding externs definitions in "codeql test" #28
Comments
|
Currently we have very limited means for passing through options from the For the specific point about externs, perhaps someone in @github/codeql-javascript can comment? |
|
I briefly discussed this with @github/codeql-javascript. It seems like we would like to assume the externs are always available in the database, and so I think we should make a pre-finalise script that extracts them. |
|
Sorry for taking this long getting back to you @franktip. I'm afraid your workaround will have to do. For a while we were considering extracting externs in tests by default, but have decided against it for two reasons:
|
|
Hi Asger, I understand that you don't want to include the externs by default for performance reasons, but would it be possible to make it an option that users need to specify/enable explicitly in a config file? I would really appreciate it if you could come up with a solution so that I won't have to copy/symlink the externs definitions in my tests. Let me know what you think. best regards, -Frank |
|
Right, adding an option for it would indeed be very useful. I'll re-open the issue, but resolution will unfortunately have to wait until the method for passing options has landed (see
|
Would it be possible to give the “codeql test” command an option to include externs and/or make this something that one can specify in a config file? Right now, the approach we have taken is to copy/symlink externs definitions into the directory containing test files, but this solution seems unsatisfactory/fragile, particularly if one wants to use the standard externs definitions.
My question relates to JavaScript, but the same issue presumably arises for other languages.