Create Fleury's_Algorithm.py #3594

DasithEdirisinghe · 2020-10-20T14:02:54Z

Describe your change:

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

TravisBuddy · 2020-10-20T14:24:06Z

Travis tests have failed

Hey @DasithEdirisinghe,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: e7cb9d20-12df-11eb-8230-47bfa5f272e1

DasithEdirisinghe · 2020-10-20T14:33:16Z

@TravisBuddy what is the log. is there any link?

TravisBuddy · 2020-10-20T14:34:39Z

Travis tests have failed

Hey @DasithEdirisinghe,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 602940f0-12e1-11eb-8230-47bfa5f272e1

TravisBuddy · 2020-10-20T14:40:26Z

Travis tests have failed

Hey @DasithEdirisinghe,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 18684e90-12e2-11eb-8230-47bfa5f272e1

TravisBuddy · 2020-10-20T14:56:22Z

Travis tests have failed

Hey @DasithEdirisinghe,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 69358250-12e4-11eb-8230-47bfa5f272e1

TravisBuddy · 2020-10-20T15:01:33Z

Travis tests have failed

Hey @DasithEdirisinghe,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 2259bfd0-12e5-11eb-8230-47bfa5f272e1

DasithEdirisinghe · 2020-10-20T16:06:57Z

@cclauss could you please help me.what is the error.I am new to this kind of issues.

cclauss · 2020-10-20T16:25:30Z

https://github.com/TheAlgorithms/Python/blob/master/Travis_CI_tests_are_failing.md

TravisBuddy · 2020-10-20T17:00:42Z

Travis tests have failed

Hey @DasithEdirisinghe,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: c7ae79c0-12f5-11eb-8230-47bfa5f272e1

DasithEdirisinghe · 2020-10-20T17:33:09Z

@cclauss I cant find the issue as the code is locally working properly.What is the issue.could you please help me?

graphs/fleurys_algorithm.py

cclauss

All functions need doctests, type hints on function parameters and return vaules, real variable names.

cclauss · 2020-10-20T19:06:23Z

graphs/fleurys_algorithm.py

+        self.v = vertices
+        self.graph = defaultdict(list)
+
+    def addEdge(self, u, v):


Suggested change

def addEdge(self, u, v):

def add_edge(self, universal: int, victorious: float) -> list[int]:

Don't force your reader to guess. Type hints are required in this repo so the caller knows what datatypes the functions expect and what datatype they return.

Single -letter variable names for function parameters is the way that programs were written in the 1950's and 60's. In modern times, we no longer force users to guess what variables mean. Instead, we give them self-documenting names.

okay thank you

graphs/fleurys_algorithm.py

cclauss · 2020-10-20T19:10:29Z

graphs/fleurys_algorithm.py

+
+            self.addEdge(u, v)
+
+            return False if count1 > count2 else True


Suggested change

return False if count1 > count2 else True

return count1 <= count2

graphs/fleurys_algorithm.py

poyea · 2020-10-29T00:59:48Z

Remember to add the hacktoberfest tag in your fork repo.

DasithEdirisinghe · 2020-10-29T02:03:07Z

Remember to add the hacktoberfest tag in your fork repo.

How to add that tag.could you please help me

stale · 2020-11-28T08:46:39Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

dhruvmanila · 2020-12-10T17:44:37Z

@algorithms-keeper review

ghost

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will only modify the labels accordingly.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

ghost · 2020-12-10T17:44:40Z

graphs/fleurys_algorithm.py

+        self.v = vertices
+        self.graph = defaultdict(list)
+
+    def add_edge(self, u, v) -> None:


Please provide doctest for the function: add_edge

ghost · 2020-12-10T17:44:40Z

graphs/fleurys_algorithm.py

+        self.graph[u].append(v)
+        self.graph[v].append(u)
+
+    def remove_edge(self, u, v) -> None:


Please provide doctest for the function: remove_edge

ghost · 2020-12-10T17:44:40Z

graphs/fleurys_algorithm.py

+            if key == u:
+                self.graph[v].pop(index)
+
+    def depth_first_search_count(self, v, visited) -> int:


Please provide doctest for the function: depth_first_search_count

ghost · 2020-12-10T17:44:41Z

graphs/fleurys_algorithm.py

+                count = count + self.dfs_count(i, visited)
+        return count
+
+    def is_valid_next_edge(self, u, v) -> bool:


Please provide doctest for the function: is_valid_next_edge

ghost · 2020-12-10T17:44:41Z

graphs/fleurys_algorithm.py

+
+            return count1 <= count2
+
+    def print_euler_util(self, u) -> None:


Please provide doctest for the function: print_euler_util

ghost · 2020-12-10T17:44:43Z

graphs/fleurys_algorithm.py

+        self.graph[u].append(v)
+        self.graph[v].append(u)
+
+    def remove_edge(self, u, v) -> None:


Please provide descriptive name for the argument: v

ghost · 2020-12-10T17:44:43Z

graphs/fleurys_algorithm.py

+            if key == u:
+                self.graph[v].pop(index)
+
+    def depth_first_search_count(self, v, visited) -> int:


Please provide descriptive name for the argument: v

ghost · 2020-12-10T17:44:43Z

graphs/fleurys_algorithm.py

+                count = count + self.dfs_count(i, visited)
+        return count
+
+    def is_valid_next_edge(self, u, v) -> bool:


Please provide descriptive name for the argument: u

ghost · 2020-12-10T17:44:43Z

graphs/fleurys_algorithm.py

+                count = count + self.dfs_count(i, visited)
+        return count
+
+    def is_valid_next_edge(self, u, v) -> bool:


Please provide descriptive name for the argument: v

ghost · 2020-12-10T17:44:44Z

graphs/fleurys_algorithm.py

+
+            return count1 <= count2
+
+    def print_euler_util(self, u) -> None:


Please provide descriptive name for the argument: u

stale · 2021-01-09T22:15:19Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale · 2021-01-17T20:13:34Z

Please reopen this pull request once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to seek help from our Gitter or ping one of the reviewers. Thank you for your contributions!

DasithEdirisinghe added 2 commits October 20, 2020 19:27

Create Fleury's_Algorithm.py

b499cb1

Update Fleury's_Algorithm.py

d33da49

Update Fleury's_Algorithm.py

a96fd55

Update Fleury's_Algorithm.py

626ea7f

Update Fleury's_Algorithm.py

8bc7460

Update Fleury's_Algorithm.py

fda57e4

DasithEdirisinghe added 2 commits October 20, 2020 22:25

Update and rename Fleury's_Algorithm.py to Fleurys_Algorithm.py

b6d9ca1

Update and rename Fleurys_Algorithm.py to fleurys_algorithm.py

8286106

DasithEdirisinghe added 6 commits October 20, 2020 22:35

Update fleurys_algorithm.py

76c7563

Update fleurys_algorithm.py

27e65ec

Update fleurys_algorithm.py

44b3b4e

Update fleurys_algorithm.py

156f1d1

Update fleurys_algorithm.py

3fc79f7

Update fleurys_algorithm.py

b462d2a

cclauss reviewed Oct 20, 2020

View reviewed changes

graphs/fleurys_algorithm.py Outdated Show resolved Hide resolved

Update fleurys_algorithm.py

4a4691e

cclauss requested changes Oct 20, 2020

View reviewed changes

cclauss added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 20, 2020

Update fleurys_algorithm.py

246ab9b

cclauss reviewed Oct 20, 2020

View reviewed changes

graphs/fleurys_algorithm.py Outdated Show resolved Hide resolved

cclauss requested changes Oct 20, 2020

View reviewed changes

graphs/fleurys_algorithm.py Outdated Show resolved Hide resolved

graphs/fleurys_algorithm.py Outdated Show resolved Hide resolved

graphs/fleurys_algorithm.py Show resolved Hide resolved

stale bot added the stale Used to mark an issue or pull request stale. label Nov 28, 2020

Apply suggestions from code review

6d8d206

ghost added require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Nov 28, 2020

stale bot removed the stale Used to mark an issue or pull request stale. label Nov 28, 2020

Whack trailing whitespace

2ffceff

ghost added the tests are failing Do not merge until tests pass label Nov 28, 2020

ghost reviewed Dec 10, 2020

View reviewed changes

stale bot added the stale Used to mark an issue or pull request stale. label Jan 9, 2021

stale bot closed this Jan 17, 2021

	def addEdge(self, u, v):
	def add_edge(self, universal: int, victorious: float) -> list[int]:

	return False if count1 > count2 else True
	return count1 <= count2


		return count1 <= count2

		def print_euler_util(self, u) -> None:

Uh oh!

Create Fleury's_Algorithm.py #3594

Create Fleury's_Algorithm.py #3594

Uh oh!

Conversation

DasithEdirisinghe commented Oct 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your change:

Checklist:

Uh oh!

TravisBuddy commented Oct 20, 2020

Travis tests have failed

TravisBuddy Request Identifier: e7cb9d20-12df-11eb-8230-47bfa5f272e1

Uh oh!

DasithEdirisinghe commented Oct 20, 2020

Uh oh!

TravisBuddy commented Oct 20, 2020

Travis tests have failed

TravisBuddy Request Identifier: 602940f0-12e1-11eb-8230-47bfa5f272e1

Uh oh!

TravisBuddy commented Oct 20, 2020

Travis tests have failed

TravisBuddy Request Identifier: 18684e90-12e2-11eb-8230-47bfa5f272e1

Uh oh!

TravisBuddy commented Oct 20, 2020

Travis tests have failed

TravisBuddy Request Identifier: 69358250-12e4-11eb-8230-47bfa5f272e1

Uh oh!

TravisBuddy commented Oct 20, 2020

Travis tests have failed

TravisBuddy Request Identifier: 2259bfd0-12e5-11eb-8230-47bfa5f272e1

Uh oh!

DasithEdirisinghe commented Oct 20, 2020

Uh oh!

cclauss commented Oct 20, 2020

Uh oh!

TravisBuddy commented Oct 20, 2020

Travis tests have failed

TravisBuddy Request Identifier: c7ae79c0-12f5-11eb-8230-47bfa5f272e1

Uh oh!

DasithEdirisinghe commented Oct 20, 2020

Uh oh!

Uh oh!

cclauss left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

poyea commented Oct 29, 2020

Uh oh!

DasithEdirisinghe commented Oct 29, 2020

Uh oh!

stale bot commented Nov 28, 2020

Uh oh!

dhruvmanila commented Dec 10, 2020

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DasithEdirisinghe commented Oct 20, 2020 •

edited

Loading