Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): support RGB alpha notation #9699

Merged
merged 3 commits into from Jan 14, 2022
Merged

feat(core): support RGB alpha notation #9699

merged 3 commits into from Jan 14, 2022
+50 −47

Conversation

@lekhmanrus
Copy link

@lekhmanrus lekhmanrus commented Dec 14, 2021

Functional notation: rgb[a](R G B[ / A])
CSS Colors Level 4 adds support for space-separated values in the functional notation.
See https://www.w3.org/TR/css-color-4/#rgb-functions

PR Checklist

What is the current behavior?

It parses rgb(1 2 3 / 4) as { f: 1, s: 255, t: 255, a: 255 }

What is the new behavior?

Supports rgb[a](R G B[ / A]) notation.
@cla-bot
Copy link

@cla-bot cla-bot bot commented Dec 14, 2021

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Ruslan Lekhman.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@lekhmanrus lekhmanrus force-pushed the rgb-alpha-notation branch from a897334 to 5ab0e77 Dec 14, 2021
@cla-bot cla-bot bot added the cla: yes label Dec 14, 2021
@lekhmanrus lekhmanrus mentioned this pull request Dec 14, 2021
Open
NathanWalker
NathanWalker previously approved these changes Dec 14, 2021
View changes
Copy link
Contributor

@NathanWalker NathanWalker left a comment

Excellent work 👏

@NathanWalker NathanWalker added this to the 8.2 milestone Dec 14, 2021
@lekhmanrus
feat(core): support RGB alpha notation
d8f9ca8 
Functional notation: rgb[a](R G B[ / A])
CSS Colors Level 4 adds support for space-separated values in the functional notation.
See https://www.w3.org/TR/css-color-4/#rgb-functions
@lekhmanrus lekhmanrus force-pushed the rgb-alpha-notation branch from 5ab0e77 to d8f9ca8 Dec 15, 2021
@lekhmanrus
Copy link
Author

@lekhmanrus lekhmanrus commented Dec 15, 2021

@NathanWalker thanks 😀

@lekhmanrus lekhmanrus requested a review from NathanWalker Dec 15, 2021
@NathanWalker NathanWalker changed the base branch from master to release/8.2.0 Jan 14, 2022
@NathanWalker NathanWalker merged commit 2337d29 into NativeScript:release/8.2.0 Jan 14, 2022
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanWalker NathanWalker

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
8.2
Linked issues

Successfully merging this pull request may close these issues.

None yet
2 participants
@lekhmanrus @NathanWalker