Add link to workflow run logs from results view #1165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeisenberg
reviewed
Feb 23, 2022
Comment on lines
95
to
97
| <TerminalIcon size={16} /> | ||
| <a className="vscode-codeql__query-file-link" href={queryResult.workflowRunUrl}> | ||
| Logs |
Contributor
There was a problem hiding this comment.
I notice that the link goes around the text. This means the icon itself is not clickable. Can you move the icon inside the link? This would be the same for the Query link above and the {queryResult.queryFileName} above that.
Contributor
Author
There was a problem hiding this comment.
Good idea! Done in a0e27f0. Had to tweak the CSS a bit, but I think it's all good now:
Plus fix the associated styling/CSS
charisk
approved these changes
Feb 25, 2022
aeisenberg
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a link to the GitHub Actions logs in the results view! (In line with our design mockups—see internal linked issue)
🖼️ 👀
Checklist
N/A - internal! 💅🏽
ready-for-doc-reviewlabel there.