Skip to content

Commit 73ab6d2

Browse files
boyanboyan
committed
enclose string literals of dictionary values with single quotes
for consistency
1 parent 5bac40a commit 73ab6d2

File tree

2 files changed

+25
-25
lines changed

2 files changed

+25
-25
lines changed

‎python2/koans/about_dictionaries.py‎

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -18,47 +18,47 @@ def test_creating_dictionaries(self):
1818
def test_dictionary_literals(self):
1919
empty_dict = {}
2020
self.assertEqual(dict, type(empty_dict))
21-
babel_fish = {'one': "uno", 'two': "dos"}
21+
babel_fish = {'one': 'uno', 'two': 'dos'}
2222
self.assertEqual(__, len(babel_fish))
2323

2424
def test_accessing_dictionaries(self):
25-
babel_fish = {'one': "uno", 'two': "dos"}
25+
babel_fish = {'one': 'uno', 'two': 'dos'}
2626
self.assertEqual(__, babel_fish['one'])
2727
self.assertEqual(__, babel_fish['two'])
2828

2929
def test_changing_dictionaries(self):
30-
babel_fish = {'one': "uno", 'two': "dos"}
31-
babel_fish['one'] = "eins"
30+
babel_fish = {'one': 'uno', 'two': 'dos'}
31+
babel_fish['one'] = 'eins'
3232

33-
expected = {'two': "dos", 'one': __}
33+
expected = {'two': 'dos', 'one': __}
3434
self.assertEqual(expected, babel_fish)
3535

3636
def test_dictionary_is_unordered(self):
37-
dict1 = {'one': "uno", 'two': "dos"}
38-
dict2 = {'two': "dos", 'one': "uno"}
37+
dict1 = {'one': 'uno', 'two': 'dos'}
38+
dict2 = {'two': 'dos', 'one': 'uno'}
3939

4040
self.assertEqual(____, dict1 == dict2)
4141

4242
def test_dictionary_keys(self):
43-
babel_fish = {'one': "uno", 'two': "dos"}
43+
babel_fish = {'one': 'uno', 'two': 'dos'}
4444
self.assertEqual(__, len(babel_fish.keys()))
4545
self.assertEqual(__, 'one' in babel_fish)
4646
self.assertEqual(__, 'two' in babel_fish)
4747
self.assertEqual(list, babel_fish.keys().__class__)
4848

4949
def test_dictionary_values(self):
50-
babel_fish = {'one': "uno", 'two': "dos"}
50+
babel_fish = {'one': 'uno', 'two': 'dos'}
5151
self.assertEqual(__, len(babel_fish.values()))
5252
self.assertEqual(__, 'uno' in babel_fish.values())
5353
self.assertEqual(__, 'dos' in babel_fish.values())
5454
self.assertEqual(list, babel_fish.values().__class__)
5555

5656
def test_making_a_dictionary_from_a_sequence_of_keys(self):
5757
cards = {}.fromkeys(
58-
("red warrior", "green elf", "blue valkyrie", "yellow dwarf",
59-
"confused looking zebra"),
58+
('red warrior', 'green elf', 'blue valkyrie', 'yellow dwarf',
59+
'confused looking zebra'),
6060
42)
6161

6262
self.assertEqual(__, len(cards))
63-
self.assertEqual(__, cards["green elf"])
64-
self.assertEqual(__, cards["yellow dwarf"])
63+
self.assertEqual(__, cards['green elf'])
64+
self.assertEqual(__, cards['yellow dwarf'])

‎python3/koans/about_dictionaries.py‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -17,45 +17,45 @@ def test_creating_dictionaries(self):
1717
def test_dictionary_literals(self):
1818
empty_dict = {}
1919
self.assertEqual(dict, type(empty_dict))
20-
babel_fish = { 'one': "uno", 'two': "dos" }
20+
babel_fish = { 'one': 'uno', 'two': 'dos' }
2121
self.assertEqual(__, len(babel_fish))
2222

2323
def test_accessing_dictionaries(self):
24-
babel_fish = { 'one': "uno", 'two': "dos" }
24+
babel_fish = { 'one': 'uno', 'two': 'dos' }
2525
self.assertEqual(__, babel_fish['one'])
2626
self.assertEqual(__, babel_fish['two'])
2727

2828
def test_changing_dictionaries(self):
29-
babel_fish = { 'one': "uno", 'two': "dos" }
30-
babel_fish['one'] = "eins"
29+
babel_fish = { 'one': 'uno', 'two': 'dos' }
30+
babel_fish['one'] = 'eins'
3131

32-
expected = { 'two': "dos", 'one': __ }
32+
expected = { 'two': 'dos', 'one': __ }
3333
self.assertDictEqual(expected, babel_fish)
3434

3535
def test_dictionary_is_unordered(self):
36-
dict1 = { 'one': "uno", 'two': "dos" }
37-
dict2 = { 'two': "dos", 'one': "uno" }
36+
dict1 = { 'one': 'uno', 'two': 'dos' }
37+
dict2 = { 'two': 'dos', 'one': 'uno' }
3838

3939
self.assertEqual(__, dict1 == dict2)
4040

4141
def test_dictionary_keys(self):
42-
babel_fish = { 'one': "uno", 'two': "dos" }
42+
babel_fish = { 'one': 'uno', 'two': 'dos' }
4343
self.assertEqual(__, len(babel_fish.keys()))
4444
self.assertEqual(__, 'one' in babel_fish)
4545
self.assertEqual(__, 'two' in babel_fish)
4646
self.assertEqual('dict_keys', babel_fish.keys().__class__.__name__)
4747

4848
def test_dictionary_values(self):
49-
babel_fish = { 'one': "uno", 'two': "dos" }
49+
babel_fish = { 'one': 'uno', 'two': 'dos' }
5050
self.assertEqual(__, len(babel_fish.values()))
5151
self.assertEqual(__, 'uno' in babel_fish.values())
5252
self.assertEqual(__, 'dos' in babel_fish.values())
5353
self.assertEqual('dict_values', babel_fish.values().__class__.__name__)
5454

5555
def test_making_a_dictionary_from_a_sequence_of_keys(self):
56-
cards = {}.fromkeys(("red warrior", "green elf", "blue valkyrie", "yellow dwarf", "confused looking zebra"), 42)
56+
cards = {}.fromkeys(('red warrior', 'green elf', 'blue valkyrie', 'yellow dwarf', 'confused looking zebra'), 42)
5757

5858
self.assertEqual(__, len(cards))
59-
self.assertEqual(__, cards["green elf"])
60-
self.assertEqual(__, cards["yellow dwarf"])
59+
self.assertEqual(__, cards['green elf'])
60+
self.assertEqual(__, cards['yellow dwarf'])
6161

0 commit comments

Comments
 (0)