Set BigQuery dataset for e2e tests (#1620)

woop · web-flow · commit 8ac997cbb9db · 2021-06-04T14:17:59.000-07:00
Signed-off-by: Willem Pienaar &lt;git@willem.co&gt;
diff --git a/sdk/python/tests/test_historical_retrieval.py b/sdk/python/tests/test_historical_retrieval.py
@@ -386,7 +386,9 @@ def test_historical_features_from_bigquery_sources(
                     online_store=SqliteOnlineStoreConfig(
                         path=os.path.join(temp_dir, "online_store.db"),
                     ),
-                    offline_store=BigQueryOfflineStoreConfig(type="bigquery",),
+                    offline_store=BigQueryOfflineStoreConfig(
+                        type="bigquery", dataset=bigquery_dataset
+                    ),
                 )
             )
         elif provider_type == "gcp":
@@ -397,7 +399,9 @@ def test_historical_features_from_bigquery_sources(
                         random.choices(string.ascii_uppercase + string.digits, k=10)
                     ),
                     provider="gcp",
-                    offline_store=BigQueryOfflineStoreConfig(type="bigquery",),
+                    offline_store=BigQueryOfflineStoreConfig(
+                        type="bigquery", dataset=bigquery_dataset
+                    ),
                 )
             )
         elif provider_type == "gcp_custom_offline_config":

Original file line number	Diff line number	Diff line change
`@@ -386,7 +386,9 @@ def test_historical_features_from_bigquery_sources(`
`386`	`386`	`online_store=SqliteOnlineStoreConfig(`
`387`	`387`	`path=os.path.join(temp_dir, "online_store.db"),`
`388`	`388`	`),`
`389`		`- offline_store=BigQueryOfflineStoreConfig(type="bigquery",),`
	`389`	`+ offline_store=BigQueryOfflineStoreConfig(`
	`390`	`+ type="bigquery", dataset=bigquery_dataset`
	`391`	`+ ),`
`390`	`392`	`)`
`391`	`393`	`)`
`392`	`394`	`elif provider_type == "gcp":`
`@@ -397,7 +399,9 @@ def test_historical_features_from_bigquery_sources(`
`397`	`399`	`random.choices(string.ascii_uppercase + string.digits, k=10)`
`398`	`400`	`),`
`399`	`401`	`provider="gcp",`
`400`		`- offline_store=BigQueryOfflineStoreConfig(type="bigquery",),`
	`402`	`+ offline_store=BigQueryOfflineStoreConfig(`
	`403`	`+ type="bigquery", dataset=bigquery_dataset`
	`404`	`+ ),`
`401`	`405`	`)`
`402`	`406`	`)`
`403`	`407`	`elif provider_type == "gcp_custom_offline_config":`