Skip to content

Commit dc6cdb8

Browse files
authored
Fix helm repo addition and dockerhub path context (#1155)
* Fix helm repo addition and dockerhub path context Signed-off-by: Terence <terencelimxp@gmail.com> * Fix env variable access and context Signed-off-by: Terence <terencelimxp@gmail.com>
1 parent 5acd905 commit dc6cdb8

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

.github/workflows/release.yml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,10 +80,11 @@ jobs:
8080
RELEASE_VERSION: ${{ needs.get-version.outputs.release_version }}
8181
with:
8282
push: true
83-
file: infra/docker/${{ matrix.component }}/Dockerfile
83+
context: .
84+
file: ./infra/docker/${{ matrix.component }}/Dockerfile
8485
tags: feastdev/feast-${{ matrix.component }}:${{ needs.get-version.outputs.release_version }}
8586
build-args: |
86-
REVISION=${RELEASE_VERSION}
87+
REVISION=$RELEASE_VERSION
8788
- name: Build and push latest
8889
uses: docker/build-push-action@v2
8990
env:
@@ -93,10 +94,11 @@ jobs:
9394
with:
9495
if: ${VERSION_WITHOUT_PREFIX} == ${HIGHEST_SEMVER_TAG:1}
9596
push: true
96-
file: infra/docker/${{ matrix.component }}/Dockerfile
97+
context: .
98+
file: ./infra/docker/${{ matrix.component }}/Dockerfile
9799
tags: feastdev/feast-${{ matrix.component }}:latest
98100
build-args: |
99-
REVISION=${RELEASE_VERSION}
101+
REVISION=$RELEASE_VERSION
100102
101103
publish-helm-charts:
102104
runs-on: ubuntu-latest

infra/scripts/sync-helm-charts.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ fi
3030

3131
exit_code=0
3232

33-
helm repo add bitnami bitnami https://charts.bitnami.com/bitnami
33+
helm repo add bitnami https://charts.bitnami.com/bitnami
3434

3535
for dir in "$repo_dir"/*; do
3636
if helm dep update "$dir" && helm dep build "$dir"; then

0 commit comments

Comments
 (0)