fix: Use context.Background() in client constructors

samuelkim7 · samuelkim7 · commit edb526a30a2c · 2026-01-23T16:13:39.000+01:00
diff --git a/go/internal/feast/onlinestore/dynamodbonlinestore.go b/go/internal/feast/onlinestore/dynamodbonlinestore.go
@@ -50,8 +50,7 @@ func NewDynamodbOnlineStore(project string, config *registry.RepoConfig, onlineS
 	}
 
 	// aws configuration
-	ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
-	defer cancel()
+	ctx := context.Background()
 	cfg, err := awsConfig.LoadDefaultConfig(ctx)
 	if err != nil {
 		panic(err)
diff --git a/go/internal/feast/registry/gcs.go b/go/internal/feast/registry/gcs.go
@@ -42,8 +42,7 @@ type GCSRegistryStore struct {
 // NewGCSRegistryStore creates a GCSRegistryStore with the given configuration.
 func NewGCSRegistryStore(config *RegistryConfig, repoPath string) *GCSRegistryStore {
 	var rs GCSRegistryStore
-	ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
-	defer cancel()
+	ctx := context.Background()
 
 	client, err := storage.NewClient(ctx)
 	if err != nil {
diff --git a/go/internal/feast/registry/s3.go b/go/internal/feast/registry/s3.go
@@ -29,22 +29,21 @@ type S3RegistryStore struct {
 
 // NewS3RegistryStore creates a S3RegistryStore with the given configuration
 func NewS3RegistryStore(config *RegistryConfig, repoPath string) *S3RegistryStore {
-	var lr S3RegistryStore
-	ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
-	defer cancel()
+	var rs S3RegistryStore
+	ctx := context.Background()
 
 	cfg, err := awsConfig.LoadDefaultConfig(ctx)
 	if err != nil {
-		lr = S3RegistryStore{
+		rs = S3RegistryStore{
 			filePath: config.Path,
 		}
 	} else {
-		lr = S3RegistryStore{
+		rs = S3RegistryStore{
 			filePath: config.Path,
 			s3Client: s3.NewFromConfig(cfg),
 		}
 	}
-	return &lr
+	return &rs
 }
 
 func (r *S3RegistryStore) GetRegistryProto() (*core.Registry, error) {

Original file line number	Diff line number	Diff line change
`@@ -50,8 +50,7 @@ func NewDynamodbOnlineStore(project string, config *registry.RepoConfig, onlineS`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`// aws configuration`
`53`		`- ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)`
`54`		`- defer cancel()`
	`53`	`+ ctx := context.Background()`
`55`	`54`	`cfg, err := awsConfig.LoadDefaultConfig(ctx)`
`56`	`55`	`if err != nil {`
`57`	`56`	`panic(err)`