feat(bigframes): Support unstable sort_values, sort_index#16665
feat(bigframes): Support unstable sort_values, sort_index#16665TrevorBergeron wants to merge 12 commits intomainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request implements stable sorting support by adding a kind parameter to sort_values and sort_index methods and updating the underlying core logic to handle sorting stability. The review feedback recommends centralizing the list of stable sort algorithms into a constant for better maintainability and suggests several refinements to type hints and default values in method overloads. Furthermore, the reviewer identified an opportunity to propagate the kind parameter when sorting DataFrames along the column axis to ensure consistent behavior.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
| inplace: bool = False, | ||
| ascending: bool = True, | ||
| na_position: __builtins__.str = "last", | ||
| kind: str | None = None, |
There was a problem hiding this comment.
Neat use of an existing pandas parameter! (https://pandas.pydata.org/docs/reference/api/pandas.Series.sort_values.html#pandas.Series.sort_values)
Interesting opportunity here too with regards to the default in pandas not being a stable sort.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕