Skip to content

ROX-33816: add db migration for soft deletes#20014

Draft
stehessel wants to merge 1 commit intoROX-33816/proto-changesfrom
ROX-33816/soft-deletes-db-migration
Draft

ROX-33816: add db migration for soft deletes#20014
stehessel wants to merge 1 commit intoROX-33816/proto-changesfrom
ROX-33816/soft-deletes-db-migration

Conversation

@stehessel
Copy link
Copy Markdown
Collaborator

Description

  • Define an index for deleted_at column in the deployments table.
  • Init deployment state as active for all currently unspecified deployments.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 15, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@stehessel stehessel force-pushed the ROX-33816/proto-changes branch from c4c23c5 to e0e556b Compare April 15, 2026 09:07
@stehessel stehessel force-pushed the ROX-33816/soft-deletes-db-migration branch from 522ccb8 to 90048bc Compare April 15, 2026 09:08
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2026

🚀 Build Images Ready

Images are ready for commit d29d52b. To use with deploy scripts:

export MAIN_IMAGE_TAG=4.11.x-645-gd29d52b566

@stehessel stehessel force-pushed the ROX-33816/proto-changes branch from e0e556b to b1d0c6d Compare April 15, 2026 09:31
@stehessel stehessel force-pushed the ROX-33816/soft-deletes-db-migration branch 2 times, most recently from 4c83dd0 to d702474 Compare April 15, 2026 13:09
@stehessel stehessel force-pushed the ROX-33816/proto-changes branch from b1d0c6d to 9aec835 Compare April 15, 2026 13:47
@stehessel stehessel force-pushed the ROX-33816/soft-deletes-db-migration branch 2 times, most recently from d986287 to 8e552f2 Compare April 15, 2026 15:23
@stehessel stehessel force-pushed the ROX-33816/proto-changes branch from 9aec835 to bd51b28 Compare April 15, 2026 20:38
@stehessel stehessel force-pushed the ROX-33816/soft-deletes-db-migration branch from 8e552f2 to d29d52b Compare April 15, 2026 20:41
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2026

Codecov Report

❌ Patch coverage is 57.14286% with 12 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (ROX-33816/proto-changes@bd51b28). Learn more about missing BASE report.

Files with missing lines Patch % Lines
central/graphql/resolvers/generated.go 50.00% 6 Missing ⚠️
...t_index_and_set_deployment_state/migration_impl.go 57.14% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##             ROX-33816/proto-changes   #20014   +/-   ##
==========================================================
  Coverage                           ?   49.56%           
==========================================================
  Files                              ?     2766           
  Lines                              ?   208483           
  Branches                           ?        0           
==========================================================
  Hits                               ?   103332           
  Misses                             ?    97494           
  Partials                           ?     7657           
Flag Coverage Δ
go-unit-tests 49.56% <57.14%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant