ROX-34007: Make `create-custom-snapshot` always run by msugakov · Pull Request #20016 · stackrox/stackrox

msugakov · 2026-04-15T09:26:24Z

Description

but skip real tasks if in PRs where Konflux is not enabled. This is alternative way to do #19892.

With the help of https://pipelinesascode.com/docs/guides/creating-pipelines/cel-expressions/.

User-facing documentation

CHANGELOG.md is updated OR update is not needed
documentation PR is created and is linked above OR is not needed

Testing and quality

the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
CI results are inspected

Automated testing

No change.

How I validated my change

Fast success in non-Konflux PR *DNM* testing of create-custom-snapshot #20026 / https://konflux-ui.apps.stone-prd-rh01.pg1f.p1.openshiftapps.com/ns/rh-acs-tenant/applications/acs/pipelineruns/create-custom-snapshot-dhxjc
1. /retest comment on the same PR - fast success - TODO
PR branch has konflux in the name - real run *DNM* testing of create-custom-snapshot - 2 #20027 / https://konflux-ui.apps.stone-prd-rh01.pg1f.p1.openshiftapps.com/ns/rh-acs-tenant/applications/acs/pipelineruns/create-custom-snapshot-ktwrj
1. /retest comment on the same PR - real run - TODO
PR has konflux-build label - real run TODO
1. /retest comment on the same PR - real run - TODO
konflux-build label added - real run TODO
1. /retest comment on the same PR - real run - TODO
release-* branch push - real run TODO

openshift-ci · 2026-04-15T09:26:29Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

codecov · 2026-04-15T09:41:15Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.61%. Comparing base (4d2dbda) to head (eed076f).
⚠️ Report is 13 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #20016      +/-   ##
==========================================
+ Coverage   49.56%   49.61%   +0.04%     
==========================================
  Files        2765     2765              
  Lines      208443   208643     +200     
==========================================
+ Hits       103322   103520     +198     
- Misses      97466    97467       +1     
- Partials     7655     7656       +1

Flag	Coverage Δ
go-unit-tests	`49.61% <ø> (+0.04%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2026-04-15T09:42:45Z

🚀 Build Images Ready

Images are ready for commit eed076f. To use with deploy scripts:

export MAIN_IMAGE_TAG=4.11.x-679-geed076faff

msugakov · 2026-04-15T12:37:25Z

Doesn't seem to work. Requested Konflux support https://redhat-internal.slack.com/archives/C04PZ7H0VA8/p1776256616552199

This reverts commit fb7166f.

github-actions · 2026-04-15T18:50:52Z

/konflux-retest main-on-push

github-actions · 2026-04-15T18:51:40Z

/konflux-retest operator-bundle-on-push

github-actions · 2026-04-15T18:56:44Z

/konflux-retest operator-bundle-on-push

github-actions · 2026-04-15T19:01:54Z

/konflux-retest operator-bundle-on-push

github-actions · 2026-04-15T19:50:18Z

/konflux-retest main-on-push

github-actions · 2026-04-15T19:55:47Z

/konflux-retest main-on-push

tommartensen · 2026-04-16T11:38:05Z

+            }
+
+            is_pull_request="false"
+            [[ "{{ pull_request_number }}" == "" ]] || is_pull_request="true"


I also saw that the pull request number was literally "{{ pull_request_number }}"

tommartensen · 2026-04-16T11:38:39Z

+            [[ "{{ pull_request_number }}" == "" ]] || is_pull_request="true"
+            assert_boolean is_pull_request "pull_request_number: {{ pull_request_number }}"
+
+            is_matching_target_branch='{{ cel: target_branch.startsWith("release-") }}'


This is interesting. Can {{ cel: ...}} be used anywhere? Are there other templating sources documented?

tommartensen · 2026-04-16T11:39:49Z

    - name: post-metric-start
      taskRef: *post-bigquery-metrics-ref

+    # TODO: event_type=on-comment and the rest


What is "the rest"?

tommartensen

This is interesting, if you want, please continue investigating!

msugakov added do-not-merge/work-in-progress konflux-build Run Konflux in PR. Push commit to trigger it. labels Apr 15, 2026

Try use CEL in task

fec0285

msugakov force-pushed the misha/change-ccs-activation-cel branch from 1e7d7bc to fec0285 Compare April 15, 2026 09:28

Try with env

9041246

Try change env to param

c4df4d4

msugakov added 3 commits April 15, 2026 11:43

Try add cel: prefix

ae8ce3d

Simplify the expression

a63e68f

Try inline

bf256a0

msugakov added 14 commits April 15, 2026 14:38

Try un-pac. per the bot's suggestion

f1154c4

Next step: simple boolean expression

b2b4d01

Try quote differently

c491d20

Try add cel:

e8416b5

Add more diagnostic

cec482a

Add more diagnostic

28a6ef4

Switch to event_type

d109483

Add target branch

e8052b5

Add source_branch to the mix

1cf49c2

Add body.pull_request to the mix

fb7166f

Revert "Add body.pull_request to the mix"

4b2c4d1

This reverts commit fb7166f.

More slowly add body

b9ae19d

Move on with body

a93cd68

Add full label expression

bb3bceb

msugakov added the ci-fail-fast Stop testing after the first test fails (not supported in all test sets) label Apr 15, 2026

msugakov added 2 commits April 15, 2026 15:42

try see what's pull_request_number

81538e6

Output body

0b3758d

msugakov added 3 commits April 15, 2026 16:43

try reduce code

1a08988

Refine and plug the task

155f3e5

fix newline

a86311c

msugakov added konflux-build Run Konflux in PR. Push commit to trigger it. and removed ci-fail-fast Stop testing after the first test fails (not supported in all test sets) konflux-build Run Konflux in PR. Push commit to trigger it. labels Apr 15, 2026

msugakov added 2 commits April 15, 2026 19:17

describe, add label activation

1b841de

Move description

3e6f9fb

msugakov added konflux-build Run Konflux in PR. Push commit to trigger it. and removed konflux-build Run Konflux in PR. Push commit to trigger it. labels Apr 15, 2026

beautify

eed076f

msugakov added konflux-build Run Konflux in PR. Push commit to trigger it. and removed konflux-build Run Konflux in PR. Push commit to trigger it. labels Apr 15, 2026

msugakov changed the title ~~Try use CEL in task~~ build: Make create-custom-snapshot always run Apr 15, 2026

msugakov changed the title ~~build: Make create-custom-snapshot always run~~ ROX-34007: Make create-custom-snapshot always run Apr 15, 2026

stackrox deleted a comment from red-hat-konflux bot Apr 15, 2026

This was referenced Apr 15, 2026

*DNM* testing of create-custom-snapshot #20026

Draft

*DNM* testing of create-custom-snapshot - 2 #20027

Draft

*DNM* testing of create-custom-snapshot - 3 #20029

Closed

tommartensen reviewed Apr 16, 2026

View reviewed changes

Conversation

msugakov commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

User-facing documentation

Testing and quality

Automated testing

How I validated my change

Uh oh!

openshift-ci bot commented Apr 15, 2026

Uh oh!

codecov bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Build Images Ready

Uh oh!

msugakov commented Apr 15, 2026

Uh oh!

github-actions bot commented Apr 15, 2026

Uh oh!

github-actions bot commented Apr 15, 2026

Uh oh!

github-actions bot commented Apr 15, 2026

Uh oh!

github-actions bot commented Apr 15, 2026

Uh oh!

github-actions bot commented Apr 15, 2026

Uh oh!

github-actions bot commented Apr 15, 2026

Uh oh!

tommartensen Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

tommartensen Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

tommartensen Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

tommartensen left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

msugakov commented Apr 15, 2026 •

edited

Loading

codecov bot commented Apr 15, 2026 •

edited

Loading

github-actions bot commented Apr 15, 2026 •

edited

Loading