WordPress.org
Get WordPress

Make WordPress Core

Opened 7 months ago

Closed 7 months ago

#63655 closed defect (bug) (invalid)

Suggestion to Add PHPDoc Block for twenty_twenty_one_can_show_post_thumbnail Filter

Reported by: viralsampat's profile viralsampat Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords:
Focuses: docs Cc:

Description

Hello Team,

While reviewing the theme files, I noticed that the twenty_twenty_one_can_show_post_thumbnail filter currently lacks a PHPDoc block.

Adding a proper PHPDoc comment would improve code clarity and enhance the overall documentation, making it easier for developers to understand and utilize the filter effectively.

Thanks,

Attachments (1)

63655.patch​ (857 bytes) - added by viralsampat 7 months ago.
I have checked above mentioned issue and resolved it. Here, I have added my patch.

Download all attachments as: .zip

Change History (2)

@viralsampat
7 months ago

I have checked above mentioned issue and resolved it. Here, I have added my patch.

#1 @sabernhardt
7 months ago

  • Keywords dev-feedback 2nd-opinion needs-testing removed
  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

The twenty_twenty_one_can_show_post_thumbnail filter already has a correct docblock:

	/**
	 * Filters whether post thumbnail can be displayed.
	 *
	 * @since Twenty Twenty-One 1.0
	 *
	 * @param bool $show_post_thumbnail Whether to show post thumbnail.
	 */

It sets the $show_post_thumbnail conditions within apply_filters(), not in a separate line.

Note: See TracTickets for help on using tickets.