Make WordPress Core

Opened 5 months ago

Closed 5 months ago

Last modified 5 months ago

#63795 closed defect (bug) (duplicate)

Suggestion: Standardizing PHPDoc Comments for Global Variables in Core Theme Files

Reported by: viralsampat's profile viralsampat Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords:
Focuses: docs Cc:

Description

Hello Team,

While reviewing the core theme files, I noticed that PHPDoc blocks are used for documenting some global variables, which is great. However, I also observed that several other global variables lack consistent PHPDoc documentation.

To improve code readability, support static analysis tools, and maintain clear documentation standards, it may be beneficial to standardize PHPDoc comments for all global variables throughout the Core codebase.

Just a suggestion that could contribute to better maintainability and developer experience.

Thank you!

Attachments (1)

63795.patch (8.6 KB) - added by viralsampat 5 months ago.
I have checked above mentioned issue and resolved it. Here, I have added my patch.

Download all attachments as: .zip

Change History (6)

@viralsampat
5 months ago

I have checked above mentioned issue and resolved it. Here, I have added my patch.

#1 @abcd95
5 months ago

Hi @viralsampat, Thanks for the ticket.

What exactly is to be tested in the doc changes?

#2 @sabernhardt
5 months ago

  • Keywords 2nd-opinion has-patch dev-feedback needs-testing removed
  • Milestone Awaiting Review deleted
  • Resolution set to duplicate
  • Status changed from new to closed

This is already part of #58715.

#3 @viralsampat
5 months ago

Hello @sabernhardt,

I have reviewed the mentioned ticket and noticed that only three themes have been modified with added PHPDoc.

I have already covered the remaining themes, so we could consider updating the PR to include those changes as well. Let me know your thoughts.

Thanks

#4 @sabernhardt
5 months ago

I checked 63795.patch​. PR 5920 already included documentation for every global variable in the patch file, and it documents additional variables for the eleven classic bundled themes.

#5 @viralsampat
5 months ago

Hello @sabernhardt

Okay, got it.

Thank you so much for detailed feedback.

Thanks,

Note: See TracTickets for help on using tickets.