Opened 4 months ago
Last modified 4 months ago
#63918 new defect (bug)
updated_..._meta meta_id is string not int - wrong docs
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | Awaiting Review | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | Options, Meta APIs | Keywords: | has-patch |
| Focuses: | Cc: |
Description
Documented as int (since it's an int in all other meta functions, e.g. "add" since it's typecast there)
Change History (4)
This ticket was mentioned in PR #9721 on WordPress/wordpress-develop by @kkmuffme.
4 months ago
#1
- Keywords has-patch added
#2
@
4 months ago
In some cases it's already typecast https://github.com/WordPress/wordpress-develop/blob/de9ae6abae047d2ea93ccd2ec2113a595ebfe8f3/src/wp-includes/meta.php#L904
Same issue also for the object id in reverse https://github.com/WordPress/wordpress-develop/blob/85350916acbe3124395bc59e2ea5feb05853085f/src/wp-includes/meta.php#L203
Also fixed in the PR
@mukesh27 commented on PR #9721:
4 months ago
#3
Does current version of code break anything? If yes, could you share a scenario where it breaks along with the steps to reproduce?
@kkmuffme commented on PR #9721:
4 months ago
#4
No, everything's working perfectly. The phpdoc types are just there to make it look fancy
Trac ticket: https://core.trac.wordpress.org/ticket/63918