Tested WP 6.3 Compatibility and Fixed User Screen Bug #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faisal-alvi
approved these changes
Sep 4, 2023
Contributor
faisal-alvi
left a comment
There was a problem hiding this comment.
LGTM. Print role changes without any error screen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR includes the bumped up version for Tested upto to 6.3 and fixes the bug that was happening in the users screen when trying to change the print roles.
Closes #123 #124
How to test the Change
As admin > Go to Users list
Select a user other than the admin role
Select "Change print role to" > Eight-day week
Click on Change button and it should update the user without any errors.
Changelog Entry
Credits
@zamanq @jeffpaul
Checklist: