Apply (char *) to static strings, exclude TSharedRef<IPlugin>plugin f…#413
Merged
rdeioris merged 3 commits into20tab:masterfrom May 17, 2018
Merged
Apply (char *) to static strings, exclude TSharedRef<IPlugin>plugin f…#413rdeioris merged 3 commits into20tab:masterfrom
rdeioris merged 3 commits into20tab:masterfrom
Conversation
…rom non editor builds to resolve issue 412
Contributor
Author
|
Tested WindowsNoEditor build on virtualbox Windows10 with subset of vs2017 components. |
Contributor
|
Thanks a lot, can you revert the PublicDefinitions renaming as it is not backward compatible ? |
Contributor
Author
|
My pleasure. Sorry about the PublicDefinitions switch - I didn't mean to add that commit to this pull request. It's been reverted to it's backwards compatible state. |
Contributor
|
Thanks a lot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply (char *) to static strings, exclude TSharedRefplugin from non editor builds to resolve issue 412.
Adding (char*) to static strings fixed the editor build. Excluding TSharedRef... fixed the command line build.
Tested on Ubuntu for editor and automated builds, but not on Windows or Mac.
It's just a couple lines changed, but feel free to edit. And, thanks for the tips in the issue report!