Skip to content

[ALICE3] TRK/Geometry: small bug fix#15112

Merged
njacazio merged 1 commit intoAliceO2Group:devfrom
AizatDaribayeva:fix-geometry
Mar 3, 2026
Merged

[ALICE3] TRK/Geometry: small bug fix#15112
njacazio merged 1 commit intoAliceO2Group:devfrom
AizatDaribayeva:fix-geometry

Conversation

@AizatDaribayeva
Copy link
Contributor

Just a small bug fix in the geometry features.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@alibuild
Copy link
Collaborator

alibuild commented Mar 2, 2026

Error while checking build/O2/fullCI_slc9 for 01a6a32 at 2026-03-02 23:36:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/aa9b3f35ca0fd74682683a24a8b1ad4e500ce95d/slc9_x86-64/o2checkcode/1.0-local100/etc/modulefiles
++ cat
--

Full log here.

@njacazio njacazio changed the title TRK/Geometry: small bug fix [ALICE3] TRK/Geometry: small bug fix Mar 3, 2026
@njacazio njacazio merged commit 3626eea into AliceO2Group:dev Mar 3, 2026
12 of 13 checks passed
@fcolamar
Copy link
Contributor

fcolamar commented Mar 3, 2026

Hi @AizatDaribayeva, @njacazio, a comment from my side: I see that this PR modifies how the retrieval of the alpha angle and of the X of a given ML/OT sensor, i.e. by subtracting the number of VD modules.
What is done, to me, seems now consistent to how the mCacheRefXMLOT are filled (starting from 0 and not from getNumberOfActivePartsVD. Anyway, I'm worried that there could still be an inconsistency on how that array is used, in the TimeFrame class.
See in particular:

alpha = gman->getSensorRefAlphaMLOT(chipID);

where there are the lines:
int chipID = hit.GetDetectorID();
alpha = gman->getSensorRefAlphaMLOT(chipID);
and I think that GetDetectorID() starts from 0 in the VD, and not in the ML (so the first element of ML is not 0 but 'getNumberOfActivePartsVD', .i.e at the moment 12 since the VD disks were removed).
Isn't there an issue of this kind?

@fcolamar
Copy link
Contributor

fcolamar commented Mar 3, 2026

Ah I see that the PR was just merged in the meantime, but let's anyway have a look at this point, thanks

@njacazio
Copy link
Collaborator

njacazio commented Mar 3, 2026

Ciao @fcolamar we can revert if needed

@fcolamar
Copy link
Contributor

fcolamar commented Mar 3, 2026

Actually re-checking it should be fine, in the getSensorRefAlphaMLOT there's indeed the subtraction by getNumberOfActivePartsVD that brings back the chip value passed as argument to 0 for the first ML module.
All clear, thanks!

@AizatDaribayeva
Copy link
Contributor Author

AizatDaribayeva commented Mar 3, 2026 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants