Skip to content

ALICE3-TRK: add noise to the digitization process #15167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
atriolo wants to merge 3 commits into
base: dev
Choose a base branch
from
+54 −3
Open

ALICE3-TRK: add noise to the digitization process #15167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b64069
ALICE3-TRK: add noise to the digitization process
atriolo Mar 16, 2026
7a4fe8a
Please consider the following formatting changes
alibuild Mar 16, 2026
5f75c28
Merge pull request #9 from alibuild/alibot-cleanup-15167
atriolo Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Detectors/Upgrades/ALICE3/TRK/simulation/include/TRKSimulation/ChipDigitsContainer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ class ChipDigitsContainer : public o2::itsmft::ChipDigitsContainer
return (static_cast<ULong64_t>(roframe) << (8 * sizeof(UInt_t))) + (static_cast<ULong64_t>(col) << (8 * sizeof(Short_t))) + row;
}

/// Adds noise digits, deleted the one using the itsmft::DigiParams interface
void addNoise(UInt_t rofMin, UInt_t rofMax, const o2::itsmft::DigiParams* params, int maxRows = o2::itsmft::SegmentationAlpide::NRows, int maxCols = o2::itsmft::SegmentationAlpide::NCols) = delete;
void addNoise(UInt_t rofMin, UInt_t rofMax, const o2::trk::DigiParams* params, int subDetID, int layer);

ClassDefNV(ChipDigitsContainer, 1);
};

Expand Down
2 changes: 1 addition & 1 deletion Detectors/Upgrades/ALICE3/TRK/simulation/include/TRKSimulation/DPLDigitizerParam.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ struct DPLDigitizerParam : public o2::conf::ConfigurableParamHelper<DPLDigitizer
private:
static constexpr float DEFNoisePerPixel()
{
return N == o2::detectors::DetID::TRK ? 1e-8 : 1e-8; // ITS/MFT values here!!
return N == o2::detectors::DetID::TRK ? 1e-7 : 1e-8; // ITS/MFT values here!!
}

static constexpr std::string_view ParamName[2] = {"TRKDigitizerParam", "FT3DigitizerParam"};
Expand Down
2 changes: 1 addition & 1 deletion Detectors/Upgrades/ALICE3/TRK/simulation/include/TRKSimulation/DigiParams.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ class DigiParams
private:
static constexpr double infTime = 1e99;
bool mIsContinuous = false; ///< flag for continuous simulation
float mNoisePerPixel = 1.e-8; ///< ALPIDE Noise per chip
float mNoisePerPixel = 1.e-7; ///< Noise per chip
int mROFrameLengthInBC = 0; ///< ROF length in BC for continuos mode
float mROFrameLength = 0; ///< length of RO frame in ns
float mStrobeDelay = 0.; ///< strobe start (in ns) wrt ROF start
Expand Down
47 changes: 47 additions & 0 deletions Detectors/Upgrades/ALICE3/TRK/simulation/src/ChipDigitsContainer.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,50 @@ using namespace o2::trk;

ChipDigitsContainer::ChipDigitsContainer(UShort_t idx)
: o2::itsmft::ChipDigitsContainer(idx) {}

//______________________________________________________________________
void ChipDigitsContainer::addNoise(UInt_t rofMin, UInt_t rofMax, const o2::trk::DigiParams* params, int subDetID, int layer)
{
UInt_t row = 0;
UInt_t col = 0;
Int_t nhits = 0;
constexpr float ns2sec = 1e-9;
float mean = 0.f;
int nel = 0;
int maxRows = 0;
int maxCols = 0;

// TODO: set different noise and threshold for VD and MLOT
if (subDetID == 0) { // VD
maxRows = constants::VD::petal::layer::nRows[layer]; // TODO: get the layer from the geometry
maxCols = constants::VD::petal::layer::nCols;
mean = params->getNoisePerPixel() * maxRows * maxCols;
nel = static_cast<int>(params->getChargeThreshold() * 1.1);
} else { // ML/OT
maxRows = constants::moduleMLOT::chip::nRows;
maxCols = constants::moduleMLOT::chip::nCols;
mean = params->getNoisePerPixel() * maxRows * maxCols;
nel = static_cast<int>(params->getChargeThreshold() * 1.1);
}

LOG(debug) << "Adding noise for chip " << mChipIndex << " with mean " << mean << " and charge " << nel;

for (UInt_t rof = rofMin; rof <= rofMax; rof++) {
nhits = gRandom->Poisson(mean);
for (Int_t i = 0; i < nhits; ++i) {
row = gRandom->Integer(maxRows);
col = gRandom->Integer(maxCols);
LOG(debug) << "Generated noise hit at ROF " << rof << ", row " << row << ", col " << col;
if (mNoiseMap && mNoiseMap->isNoisy(mChipIndex, row, col)) {
continue;
}
if (mDeadChanMap && mDeadChanMap->isNoisy(mChipIndex, row, col)) {
continue;
}
auto key = getOrderingKey(rof, row, col);
if (!findDigit(key)) {
addDigit(key, rof, row, col, nel, o2::MCCompLabel(true));
}
}
}
}
2 changes: 1 addition & 1 deletion Detectors/Upgrades/ALICE3/TRK/simulation/src/Digitizer.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ void Digitizer::fillOutputContainer(uint32_t frameLast)
if (chip.isDisabled()) {
continue;
}
// chip.addNoise(mROFrameMin, mROFrameMin, &mParams); /// TODO: add noise
chip.addNoise(mROFrameMin, mROFrameMin, &mParams, mGeometry->getSubDetID(chip.getChipIndex()), mGeometry->getLayer(chip.getChipIndex())); /// TODO: add noise
auto& buffer = chip.getPreDigits();
if (buffer.empty()) {
continue;
Expand Down
Loading