Validity range fix; debug info added#8430
Conversation
shahor02
left a comment
There was a problem hiding this comment.
@peressounko please see the comment below. In general, would be good to gradually switch to DPL CCDB fetcher instead of modifying the code using BasicCCDBManager.
There was a problem hiding this comment.
above you change to this: https://github.com/AliceO2Group/AliceO2/blob/9e546ae0d3a1199026eb910316b7bee97cd84bae/Detectors/PHOS/calib/src/PHOSBadMapCalibDevice.cxx#L137-L145
and here you again use PHS/Calib/BadMap. Could you cross-check?
There was a problem hiding this comment.
Thank you for careful reading. Idea is to store intermediate maps from different methods in PHS/BadMap and manually combine them to final map stored in PHS/Calib/BadMap.
There was a problem hiding this comment.
Why manual (which we want to avoid). How often will you do this?
There was a problem hiding this comment.
Ingredients of bad map will be run automatically. Combination will be done once per modification of electronics ~ as in Run2 per period or few periods.
|
Concerning switching to CCDB fetcher - I see your exchange with Sergey, probably I will switch when everything will be fixed/checked and I can use his code as an example. |
|
Can not find what is the problem in build/O2/o2-dataflow-cs8? |
ccdb path fixed;Validity range fix; debug info added