[O2B-1533] Adjust detector type ordering in DetectorsProvider#2084
Open
isaachilly wants to merge 7 commits intomainfrom
Open
[O2B-1533] Adjust detector type ordering in DetectorsProvider#2084isaachilly wants to merge 7 commits intomainfrom
isaachilly wants to merge 7 commits intomainfrom
Conversation
Move the MUON-GLO, AOT-EVENT, AOT-GLO detectors to appear at the end of the runs-per-data-pass table on request.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2084 +/- ##
==========================================
- Coverage 45.57% 45.56% -0.01%
==========================================
Files 1042 1043 +1
Lines 17322 17325 +3
Branches 3136 3137 +1
==========================================
Hits 7894 7894
- Misses 9428 9431 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Accept a detectorOrder ENUM in the DetectorsProvider constructor and sort by it.
Export a new rctDetectorsProvider (DetectorsProvider configured with DetectorOrders.RCT) and update RCT tables.
Add a test to verify detector columns are rendered in RCT order. Update the CSV export expectations to reflect the new column ordering (CPV/VTX swapped).
Add tests to verify detector columns are rendered in RCT order on runs-per-lhc-period and runs-per-simulation-pass pages.
Centralise detector ordering maps by moving DEFAULT and RCT switchCase inputs into the ENUM. This consolidates ordering configuration and avoids duplicate definitions in the provider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the MUON-GLO, AOT-EVENT, AOT-GLO detectors to appear towards the end of RCT table's.
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
Changes made to the database: