Skip to content

[MFT] shorten message boxes on occupancy summaries #2651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Edingrast merged 7 commits into from
Mar 13, 2026
Merged

[MFT] shorten message boxes on occupancy summaries #2651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4f45379
changed message for medium quality
jjuracka Jan 14, 2026
177a399
changed messages for medium quality
jjuracka Jan 14, 2026
fc37d68
Merge branch 'AliceO2Group:master' into ladderChecker
jjuracka Jan 26, 2026
bc85e3e
Merge branch 'AliceO2Group:master' into ladderChecker
jjuracka Mar 2, 2026
28c324f
Merge branch 'AliceO2Group:master' into ladderChecker
jjuracka Mar 12, 2026
3ba9be8
adjust quality message width
jjuracka Mar 12, 2026
67b2bd2
capitalise quality
jjuracka Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Modules/MFT/src/QcMFTClusterCheck.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,32 +306,32 @@ void QcMFTClusterCheck::beautify(std::shared_ptr<MonitorObject> mo, Quality chec

if (mo->getName().find("mClusterOccupancySummary") != std::string::npos) {
auto* hOccupancySummary = dynamic_cast<TH2F*>(mo->getObject());
TPaveText* msg1 = new TPaveText(0.05, 0.9, 0.35, 1.0, "NDC NB");
TPaveText* msg2 = new TPaveText(0.65, 0.9, 0.95, 1.0, "NDC NB");
TPaveText* msg1 = new TPaveText(0.10, 0.9, 0.35, 1.0, "NDC NB");
TPaveText* msg2 = new TPaveText(0.65, 0.9, 0.90, 1.0, "NDC NB");
hOccupancySummary->GetListOfFunctions()->Add(msg1);
hOccupancySummary->GetListOfFunctions()->Add(msg2);
msg1->SetName(Form("%s_msg1", mo->GetName()));
msg2->SetName(Form("%s_msg2", mo->GetName()));
if (checkResult == Quality::Good) {
LOG(info) << "Quality::Good";
msg1->Clear();
msg1->AddText("Quality Good");
msg1->AddText("Quality GOOD");
msg1->SetFillColor(kGreen);
msg2->Clear();
msg2->AddText("No action needed");
msg2->SetFillColor(kGreen);
} else if (checkResult == Quality::Medium) {
LOG(info) << "Quality::Medium";
msg1->Clear();
msg1->AddText("Quality medium");
msg1->AddText("Quality MEDIUM");
msg1->SetFillColor(kOrange);
msg2->Clear();
msg2->AddText("Write a logbook entry tagging MFT");
msg2->AddText("Refer to QC instructions");
msg2->SetFillColor(kOrange);
} else if (checkResult == Quality::Bad) {
LOG(info) << "Quality::Bad";
msg1->Clear();
msg1->AddText("Quality bad");
msg1->AddText("Quality BAD");
msg1->SetFillColor(kRed);
msg2->Clear();
msg2->AddText("Call the on-call!");
Expand Down
14 changes: 7 additions & 7 deletions Modules/MFT/src/QcMFTDigitCheck.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@ void QcMFTDigitCheck::beautify(std::shared_ptr<MonitorObject> mo, Quality checkR
msg->AddText("No action needed");
} else if (mQualityMedium) {
QualityColor = kOrange;
msg->AddText("Write a logbook entry tagging MFT");
msg->AddText("Refer to QC instructions");
} else if (mQualityBad) {
QualityColor = kRed;
msg->AddText("Call the on-call!");
Expand Down Expand Up @@ -479,16 +479,16 @@ void QcMFTDigitCheck::beautify(std::shared_ptr<MonitorObject> mo, Quality checkR

if (mo->getName().find("mDigitOccupancySummary") != std::string::npos) {
auto* hDigitOccupancySummary = dynamic_cast<TH2F*>(mo->getObject());
TPaveText* msg1 = new TPaveText(0.05, 0.9, 0.35, 1.0, "NDC NB");
TPaveText* msg2 = new TPaveText(0.65, 0.9, 0.95, 1.0, "NDC NB");
TPaveText* msg1 = new TPaveText(0.10, 0.9, 0.35, 1.0, "NDC NB");
TPaveText* msg2 = new TPaveText(0.65, 0.9, 0.90, 1.0, "NDC NB");
hDigitOccupancySummary->GetListOfFunctions()->Add(msg1);
hDigitOccupancySummary->GetListOfFunctions()->Add(msg2);
msg1->SetName(Form("%s_msg", mo->GetName()));
msg2->SetName(Form("%s_msg2", mo->GetName()));
if (checkResult == Quality::Good) {
LOG(info) << "Quality::Good";
msg1->Clear();
msg1->AddText("Quality Good");
msg1->AddText("Quality GOOD");
msg1->SetFillColor(kGreen);
msg1->Draw();
msg2->Clear();
Expand All @@ -498,17 +498,17 @@ void QcMFTDigitCheck::beautify(std::shared_ptr<MonitorObject> mo, Quality checkR
} else if (checkResult == Quality::Medium) {
LOG(info) << "Quality::Medium";
msg1->Clear();
msg1->AddText("Quality medium");
msg1->AddText("Quality MEDIUM");
msg1->SetFillColor(kOrange);
msg1->Draw();
msg2->Clear();
msg2->AddText("Write a logbook entry tagging MFT");
msg2->AddText("Refer to QC instructions");
msg2->SetFillColor(kOrange);
msg2->Draw();
} else if (checkResult == Quality::Bad) {
LOG(info) << "Quality::Bad";
msg1->Clear();
msg1->AddText("Quality bad");
msg1->AddText("Quality BAD");
msg1->SetFillColor(kRed);
msg1->Draw();
msg2->Clear();
Expand Down
Loading