Add send_subscriber_agreement function#1
Merged
kerrermanisNL merged 3 commits intobytefrom Aug 5, 2016
Merged
Conversation
xolphin/endpoint/request.py
Outdated
| })) | ||
|
|
||
| def send_subscriber_agreement(self, id, email, language='nl'): | ||
| return Base(self.client.post('requests/{id}/sa'.format(id=id), { |
Author
There was a problem hiding this comment.
Used '{id}'.format() here, but the other functions use '%d' % id. I went for this, but maybe it needs to be the "old" style to support older versions of Python?
Member
There was a problem hiding this comment.
This is fine for us, but I'd suggest using the method used in the rest of the code if you plan on submitting the code upstream again. Code consistency FTW and all
|
Awesome, would be really nice. |
allardhoeve
pushed a commit
that referenced
this pull request
May 4, 2017
…_option Add send subscriber agreement option
tdgroot
pushed a commit
that referenced
this pull request
Feb 16, 2026
Disable free san in renew and reissue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Able to send subscriber agreement via API wrapper.