This repository was archived by the owner on Jan 14, 2024. It is now read-only.
North West 4 - Omer Yamak - HTML-CSS - Week 1#125
Open
omerffaruk wants to merge 5 commits intoCodeYourFuture:masterfrom
Open
North West 4 - Omer Yamak - HTML-CSS - Week 1#125omerffaruk wants to merge 5 commits intoCodeYourFuture:masterfrom
omerffaruk wants to merge 5 commits intoCodeYourFuture:masterfrom
Conversation
Html structure is completed and webpage content has been provided
Header, font throughout the page, footer styled. Header sticky is not working properly, articles do not include summary and link, page is not responsive, solve the margin-layout issues, footer should include information about the page or you, check the semantic elements use, use :first-child pseudo class to style the first article so that it stands out from the others,
Header sticky issue solved, articles now include summary and link, page is now responsive (still could be better though), used :first-child pseudo class to style the first article so that it stands out from the others. Issues to solve: margin-layout issues especially in article flex-box model, footer should include information about the page or you, check the semantic elements use.
Margin-layout issues especially in article flex-box model solved, footer includes facebook and twitter icon links, html code uses semantic elements. Page could be better in terms of being responsive page
did some minor css styling changes to make the webpage more responsive, changed the color of the .about
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?