London 9 - Sahar Naderi - HTML/CSS - WEEK 1#271
London 9 - Sahar Naderi - HTML/CSS - WEEK 1#271SaharNaderi wants to merge 1 commit intoCodeYourFuture:masterfrom
Conversation
There was a problem hiding this comment.
Hi Sahar,
The code here is consistently pretty solid - it's great to see your use of flex boxes for the page structure, and the semantic HTML is lovely to see too. There is quite a lot of use of absolute units, but I can see from your later work that this is a habit you are breaking!
Stylistically, I would always declare a font family on any webpage. Browser defaults can be really ugly. Fonts are tricky across browsers and operating systems, so Google Fonts is a really good way of managing this process: https://www.freecodecamp.org/news/how-to-use-google-fonts-in-your-next-web-design-project-e1ad48f1adfa/
There are some minor formatting mistakes, nothing dramatic, but again looking into some tooling in VS Code will be really helpful here.
Overall I think you're demonstrating a good grasp over the fundamentals of layout and the use of HTML/CSS.
| font-size: 20px; | ||
| } | ||
|
|
||
| span { |
There was a problem hiding this comment.
I would use a class here, applying a blanket styling rule to a span element is pretty dangerous as we want them to be flexible parent containers for other elements.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?