This repository was archived by the owner on Oct 26, 2020. It is now read-only.
Open
Conversation
pads
approved these changes
Jul 4, 2020
pads
left a comment
There was a problem hiding this comment.
Well done Ali. One minor thing to point out is that it helps make the code easier to read when there are consistent spaces between operators. A couple of examples:
(price/100*20) + price->(price / 100 * 20) + price.firstWord+" "+secondWord+" "+thirdWord->firstWord + "" + secondWord + "" + thirdWord
Overall, this is nice work and you have shown good understanding here.
|
|
||
| // Add comments to explain what this function does. You're meant to use Google! | ||
| // concat() method is used to combine or join two strings. | ||
| // In this function w2 is added to the infront of w1. |
There was a problem hiding this comment.
This is almost right! If you try running this function by providing string inputs w1 and w2 where does w2 go?
| function concatenate(firstWord, secondWord, thirdWord) { | ||
| // Write the body of this function to concatenate three words together | ||
| // Look at the test case below to understand what to expect in return | ||
| return firstWord+" "+secondWord+" "+thirdWord |
There was a problem hiding this comment.
This definitely works but could you think of another way of doing this, perhaps using concat?
pads
reviewed
Jul 4, 2020
| { | ||
| // Use IntelliSense to learn about possible attributes. | ||
| // Hover to view descriptions of existing attributes. | ||
| // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387 |
There was a problem hiding this comment.
Just to let you know, the reason this code has appeared red is because comments are not allowed in JSON files.
pads
approved these changes
Jul 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your Details
Your Name: Ali Haider
Your City: Birmingham
Your Slack Name: Ali Haider
Homework Details
Module: Javascript
Week: 1