Skip to content

preliminary hosting integration #2318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
akiraveliara wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

preliminary hosting integration #2318

akiraveliara wants to merge 1 commit into from

Conversation

@akiraveliara
Copy link
Member

@akiraveliara akiraveliara commented May 12, 2025

open questions:

  • do we want setup symmetry with DiscordClientBuilder and IServiceCollection?
  • do we also want to support IHostApplicationBuilder today, which is newer and preferred per Microsoft's documentation, but we won't be able to adhere to its setup pattern until .NET 10 brings extension properties?
  • do we want to integrate fetching the token with IConfiguration?

@akiraveliara akiraveliara added this to the v5.0 milestone May 12, 2025
@Plerx2493
Copy link
Member

Plerx2493 commented May 17, 2025

  • i dont think we need. The biggest point was the hosted service. Imo its not necessary to also provide the other methods another time for the hostbuilder
  • im not sure what the implications are
  • if we do that we kinda force the user to use that exact configuration scheme if im not wrong, so i dont really think its a good idea. Maybe let the user provide a Func<IConfiguration, string> to select the token from the config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

v5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@akiraveliara @Plerx2493