Try to resolve the issue of socket port listening failure #1007
+66
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlorianRappl
approved these changes
Jan 15, 2026
Collaborator
FlorianRappl
left a comment
There was a problem hiding this comment.
From my perspective that works and is fine - only thing we might (want to?) improve is the "+ 2". I'd much rather prefer a random port that is placed between 5_000 and 65_535 excl. the already bound ports (local addresses) and previous attempts.
Thanks a lot for the awesome and swift work! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1006 In the
GetFreePort()method, add an attempt to listen on the port to ensure the returned port is available for listening.