Skip to content

fix(ui): embed rebuilt admin UI with bug fixes#1

Closed
intel352 wants to merge 1 commit intomainfrom
bugfix/ui-dist-update
Closed

fix(ui): embed rebuilt admin UI with bug fixes#1
intel352 wants to merge 1 commit intomainfrom
bugfix/ui-dist-update

Conversation

@intel352
Copy link
Contributor

Summary

Rebuilds and embeds the admin UI dist from the latest workflow UI source (bugfix/admin-ui-fixes branch).

Fixes included in this dist:

  • HIGH — Logout button (already in AppNav) is now properly embedded and visible
  • MEDIUM — Login error mapped to user-friendly "Invalid email or password"
  • LOW — Password autocomplete attributes on all password inputs

Test plan

  • Deploy and verify logout button (🚪) appears at bottom of sidebar
  • Attempt login with wrong credentials — verify friendly error message
  • Verify password manager autocomplete hints work on login/register forms

🤖 Generated with Claude Code

Includes:
- Logout button (already in AppNav) now embedded in dist
- Login error shows 'Invalid email or password' instead of raw JSON
- autocomplete attributes on all password inputs

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@intel352
Copy link
Contributor Author

Closing this PR in favor of #2, which takes a different approach.

Rather than tracking compiled UI assets in git, the new approach:

  1. Keeps only a placeholder index.html in internal/ui_dist/ (sufficient for //go:embed during dev builds)
  2. Adds a .gitignore to prevent compiled assets from being committed
  3. Builds the UI from source at release time in the GitHub Actions workflow

This avoids bloating the repo with compiled artifacts that become stale and need to be manually rebuilt and re-committed for every UI change. The bug fixes from the workflow UI (logout button, login error messages, password autocomplete) will be picked up automatically by the release workflow when it builds from the latest workflow source.

@intel352 intel352 closed this Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant