chore(deps): update dependency cryptography to v46#13993
chore(deps): update dependency cryptography to v46#13993renovate-bot wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the cryptography dependency to version 46.0.6 across several requirements files. Feedback indicates that this update introduces a breaking change in the kms/attestations module, as the new version of the library changes the signature of the public_bytes method, which will cause a runtime TypeError.
| @@ -1,4 +1,4 @@ | |||
| cryptography==45.0.1 | |||
| cryptography==46.0.6 | |||
There was a problem hiding this comment.
Updating to cryptography v46 is a breaking change for the code in this directory. Specifically, in kms/attestations/verify_attestation_chains.py on line 227, the call mfr_root_cert.subject.public_bytes(backends.default_backend()) will fail.
In cryptography 46.0.0, the public_bytes method on Name objects (returned by the .subject property) was updated to require an encoding argument (e.g., serialization.Encoding.DER) and the backend argument was removed. This will result in a TypeError at runtime because the backend object is no longer accepted.
Please update the code in verify_attestation_chains.py to use mfr_root_cert.subject.public_bytes(serialization.Encoding.DER) or pin the dependency to <46.0.0 until the code can be updated.
This PR contains the following updates:
==45.0.1→==46.0.6Release Notes
pyca/cryptography (cryptography)
v46.0.6Compare Source
v46.0.5Compare Source
v46.0.4Compare Source
v46.0.3Compare Source
v46.0.2Compare Source
v46.0.1Compare Source
v46.0.0Compare Source
v45.0.7Compare Source
v45.0.6Compare Source
v45.0.5Compare Source
v45.0.4Compare Source
v45.0.3Compare Source
v45.0.2Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Never, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.