Change greeting from 'Hello, World!' to 'Hello, Pranay'#14044
Change greeting from 'Hello, World!' to 'Hello, Pranay'#14044pranay1222 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request updates the greeting message in the hello_world application from a generic 'Hello, World!' to a specific name. The reviewer recommends reverting this change to ensure the code sample remains general-purpose and professional, providing a code suggestion to restore the original greeting.
| def get(self): | ||
| self.response.headers["Content-Type"] = "text/plain" | ||
| self.response.write("Hello, World!") | ||
| self.response.write("Hello, Pranay") |
There was a problem hiding this comment.
In public-facing code samples, it is standard practice to use generic greetings like 'Hello, World!' rather than specific names. This ensures the sample remains general-purpose and professional for all users.
| self.response.write("Hello, Pranay") | |
| self.response.write("Hello, World!") |
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)