Skip to content

Adds equivalents to api-client for cloud-client#775

Merged
theacodes merged 2 commits intomasterfrom
speech-cloud-client
Feb 1, 2017
Merged

Adds equivalents to api-client for cloud-client#775
theacodes merged 2 commits intomasterfrom
speech-cloud-client

Conversation

@gguuss
Copy link
Copy Markdown
Contributor

@gguuss gguuss commented Feb 1, 2017

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 1, 2017
@@ -0,0 +1,67 @@
#!/usr/bin/env python
# Copyright 2016 Google Inc. All Rights Reserved.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's 2017, brother!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@@ -0,0 +1,67 @@
#!/usr/bin/env python
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line after shebang, please.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line between license and docstring, please.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@gguuss
Copy link
Copy Markdown
Contributor Author

gguuss commented Feb 1, 2017

PTAL

@theacodes theacodes merged commit a656105 into master Feb 1, 2017
@theacodes theacodes deleted the speech-cloud-client branch February 1, 2017 23:40
busunkim96 pushed a commit to busunkim96/python-speech that referenced this pull request Sep 1, 2020
busunkim96 pushed a commit to googleapis/python-speech that referenced this pull request Sep 3, 2020
atulep pushed a commit to googleapis/google-cloud-python that referenced this pull request Apr 6, 2023
atulep pushed a commit to googleapis/google-cloud-python that referenced this pull request Apr 6, 2023
atulep pushed a commit to googleapis/google-cloud-python that referenced this pull request Apr 18, 2023
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants